armv8m: make the debugger handle better faults through ICSR #2187

mean00 commented 2026年02月01日 19:15:49 +01:00 (Migrated from github.com)

Detailed description

The ArmV8m does not handle faults the same way. The two main differences are :

• The fault will trigger BEFORE executing the fault rather than after
• The info is split between between DFSR and the new ICSR

As a result the current code does not handle fault very well.
Put a breakpoint on a fault (for example asm("udf #0") and try to "si" on it.

Gdb will appear to get stuck there because the debugger will see the state BEFORE the fault is actually executed and as a result not detect the fault.

The MR adds a separate path that , for ArmV8M, it checks if a fault is pending on ICSR
The "si" command on a fault now works and you proceed on to the handler.

I tested it on a RP2350 and on another CortexM33 successfully.
I'm not convinced all cases are covered as some parts are configurable, but at least it's working better.

Not sure either if the new two new registers should be renamed with V8M in the name or something.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (see Building the firmware)
• It builds as BMDA (see Building the BMDA)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

N/A

<!-- Filling this template is mandatory --> ## Detailed description The ArmV8m does not handle faults the same way. The two main differences are : - The fault will trigger BEFORE executing the fault rather than after - The info is split between between DFSR and the new ICSR - As a result the current code does not handle fault very well. Put a breakpoint on a fault (for example __asm__("udf #0") and try to "si" on it. Gdb will appear to get stuck there because the debugger will see the state BEFORE the fault is actually executed and as a result not detect the fault. The MR adds a separate path that , for ArmV8M, it checks if a fault is pending on ICSR The "si" command on a fault now works and you proceed on to the handler. I tested it on a RP2350 and on another CortexM33 successfully. I'm not convinced all cases are covered as some parts are configurable, but at least it's working better. Not sure either if the new two new registers should be renamed with _V8M_ in the name or something. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues N/A

mean00 commented 2026年02月04日 07:20:28 +01:00 (Migrated from github.com)

I'll update the MR this weekend
Thank you

I'll update the MR this weekend Thank you

mean00 commented 2026年02月07日 16:04:36 +01:00 (Migrated from github.com)

I think i got all the remarks as a separate commit for easy review
If that's ok, i'll squash them, it takes 10 sec to do so
Thank you

I think i got all the remarks as a separate commit for easy review If that's ok, i'll squash them, it takes 10 sec to do so Thank you

mean00 commented 2026年02月10日 19:53:56 +01:00 (Migrated from github.com)

This time i think it's correct. I've squashed it as the last change was really small & easy to check.
(slightly altered the commit comment to be in line with the naming for ARMv8-M)
Thank you.

This time i think it's correct. I've squashed it as the last change was really small & easy to check. (slightly altered the commit comment to be in line with the naming for ARMv8-M) Thank you.

dragonmux commented 2026年02月11日 12:59:33 +01:00

It would technically be cortexm: for the commit message suffix as it's not based on the concept touched, but which file is touched.. however, we're going to approve and merge this as it stands as it looks good.

It would technically be `cortexm: ` for the commit message suffix as it's not based on the concept touched, but which file is touched.. however, we're going to approve and merge this as it stands as it looks good.