7
31
Fork
You've already forked blackmagic
23

Feature: detect GD32VW553 #2186

Merged
ALTracer merged 3 commits from feature/gd32vw553 into main 2026年02月02日 06:02:48 +01:00
ALTracer commented 2026年02月01日 14:37:12 +01:00 (Migrated from github.com)
Copy link

Detailed description

  • This a minor new feature (target support).
  • The existing problem is unknown idcode 0x10307a6d of Gigadevice GD32VW553 SoC and hence no autodetection.
  • This PR solves it by registering relevant ident codes. No flash driver yet though.

Not tested as I don't have that board, only GD32VF103. But going by the logs, it makes sense:
Info : JTAG tap: gd32vw553.cpu tap/device found: 0x10307a6d (mfg: 0x536 (Nuclei System Technology Co Ltd), part: 0x0307, ver: 0x1)
Info : JTAG tap: auto0.tap tap/device found: 0x790007a3 (mfg: 0x3d1 (GigaDevice Semiconductor (Beijing)), part: 0x9000, ver: 0x7)
There is valuable internal cleanup w.r.t. JTAG and generic RISC-V probe paths. I can discard gd32vw5_probe() stub, and the weak nop mechanism will simply return false for it.

Your checklist for this pull request

Closing issues

## Detailed description * This a minor new feature (target support). * The existing problem is unknown idcode 0x10307a6d of Gigadevice GD32VW553 SoC and hence no autodetection. * This PR solves it by registering relevant ident codes. No flash driver yet though. Not tested as I don't have that board, only GD32VF103. But going by the logs, it makes sense: `Info : JTAG tap: gd32vw553.cpu tap/device found: 0x10307a6d (mfg: 0x536 (Nuclei System Technology Co Ltd), part: 0x0307, ver: 0x1)` `Info : JTAG tap: auto0.tap tap/device found: 0x790007a3 (mfg: 0x3d1 (GigaDevice Semiconductor (Beijing)), part: 0x9000, ver: 0x7)` There is valuable internal cleanup w.r.t. JTAG and generic RISC-V probe paths. I can discard `gd32vw5_probe()` stub, and the weak nop mechanism will simply return false for it. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [ ] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues
dragonmux left a comment
Copy link

Only got a couple of relatively small notes. With them addressed, we'll be happy to merge this as this looks great!

Only got a couple of relatively small notes. With them addressed, we'll be happy to merge this as this looks great!
@ -410,11 +410,19 @@ const jtag_dev_descr_s dev_descr[] = {
.idcode = 0x0000563dU,

We would like to keep the more generic string here, as while this is useful, the generic string pools and thus doesn't take additional space up.. If we do keep this revised string, we would prefer to see something like "Andes Tech RV DTM." - with the . included for consistency with the other entries.

We would like to keep the more generic string here, as while this is useful, the generic string pools and thus doesn't take additional space up.. If we do keep this revised string, we would prefer to see something like "Andes Tech RV DTM." - with the `.` included for consistency with the other entries.

Similar note here.

Similar note here.
dragonmux left a comment
Copy link

LGTM, merging. Thank you for the contribution!

LGTM, merging. Thank you for the contribution!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2186
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "feature/gd32vw553"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?