7
31
Fork
You've already forked blackmagic
23

Fix: remove last VLA in msp432p4.c #2183

Merged
ALTracer merged 1 commit from fix/alloca-msp432p4 into main 2026年02月02日 02:25:14 +01:00
ALTracer commented 2026年02月01日 10:58:16 +01:00 (Migrated from github.com)
Copy link

Detailed description

  • Not a new feature.
  • The existing problem is VLA/alloca left over from PR1606 refactoring, specifically v1.9.0-1188-g f94ed09c.
  • This PR completes the replacement (to arrays with known size of 20+33 matching Cortex-M4F).

Found using ag alloca\\\( src/, also matches git grep "alloca(" origin/main -- src/target/*.c. Related: v1.10.0-244-g c0a8672f of PR1661.
Not tested.

Your checklist for this pull request

Closing issues

## Detailed description * Not a new feature. * The existing problem is VLA/alloca left over from PR1606 refactoring, specifically v1.9.0-1188-g f94ed09c. * This PR completes the replacement (to arrays with known size of 20+33 matching Cortex-M4F). Found using `ag alloca\\\( src/`, also matches `git grep "alloca(" origin/main -- src/target/*.c`. Related: v1.10.0-244-g c0a8672f of PR1661. Not tested. ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [ ] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues
dragonmux left a comment
Copy link

LGTM, merging. Thank you for the contribution!

LGTM, merging. Thank you for the contribution!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
BMD App
Black Magic Debug App (aka. PC hosted) (not firmware)
BMP Firmware
Black Magic Probe Firmware (not PC hosted software)
Bug
Confirmed bug
Build system
Build system
Can't reproduce
Maintainers can't reproduce this problem
CI
Continuous Integration System
Contribution wanted
User contributions welcome
Documentation
Project documentation
Draft
Work in progress draft
Duplicate
This issue or pull request already exists
Enhancement
General project improvement
Feedback wanted
Requires additional submitter feedback
Foreign Host Board
Non Native hardware to runing Black Magic firmware on
GDB
Issue/PR related to GDB
Good first issue
Good for newcommers
HwIssue Mitigation
Solving or mitigating a Hardware issue in Software
Information Needed
Maintainers need more information
NativeHardware
Official Black Magic Debug Hardware
New Host Board
New hardware to run Black Magic firmware on
New Target
New debug target
Off Topic
Something that does not involve the project in any way
Potential Bug
A potential, unconfirmed or very special circumstance bug
Regression
Bug caused by a regression
User Interest Needed
More user interest required before consideration
User Testing Needed
Looking for user testing reports
Won't fix
Outside of the project scope or works as intended
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
blackmagic-debug/blackmagic!2183
Reference in a new issue
blackmagic-debug/blackmagic
No description provided.
Delete branch "fix/alloca-msp432p4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?