Feature/misc meson improvements #1992

perigoso commented 2024年11月04日 12:14:35 +01:00 (Migrated from github.com)

Detailed description

This is a minor cleanup/simplification of the meson configuration around the target enabling

This should result in no behavior changes, except for a small, but very intentional one.

Right now when manually configuring the build, i.e. not using the pre-made cross-files for the probes, the default behaviour was to enable all targets by default, resulting in the need to safe-guard against special cases for certain probes to reduce user confusion.

This changes things such that by default when manually configuring the build no targets are enabled by default, a helpful error message should be displayed about it (improvement over the previous compilation error).

I think this makes sense because this is to me an "advanced user" usage and reduces the maintenance burden on the build system.

Your checklist for this pull request

• I've read the Code of Conduct
• I've read the guidelines for contributing to this repository
• It builds for hardware native (see Building the firmware)
• It builds as BMDA (see Building the BMDA)
• I've tested it to the best of my ability
• My commit messages provide a useful short description of what the commits do

Closing issues

<!-- Filling this template is mandatory --> ## Detailed description This is a minor cleanup/simplification of the meson configuration around the target enabling This should result in *no* behavior changes, except for a small, but very intentional one. Right now when *manually* configuring the build, i.e. not using the pre-made cross-files for the probes, the default behaviour was to enable *all* targets by default, resulting in the need to safe-guard against special cases for certain probes to reduce user confusion. This changes things such that by default when *manually* configuring the build *no* targets are enabled by default, a helpful error message should be displayed about it (improvement over the previous compilation error). I think this makes sense because this is to me an "advanced user" usage and reduces the maintenance burden on the build system. <!-- Explain the **details** for making this change. * Is a new feature implemented? * What existing problem(s) does the pull request solve? * How does the pull request solve these problems? Please provide enough information so that others can review your pull request. Information embedded in the description part of the commits doesn't count. --> ## Your checklist for this pull request * [x] I've read the [Code of Conduct](https://github.com/blackmagic-debug/blackmagic/blob/main/CODE_OF_CONDUCT.md) * [x] I've read the [guidelines for contributing](https://github.com/blackmagic-debug/blackmagic/blob/main/CONTRIBUTING.md) to this repository * [x] It builds for hardware native (see [Building the firmware](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-firmware)) * [x] It builds as BMDA (see [Building the BMDA](https://github.com/blackmagic-debug/blackmagic?tab=readme-ov-file#building-black-magic-debug-app)) * [x] I've tested it to the best of my ability * [x] My commit messages provide a useful short description of what the commits do ## Closing issues <!-- put "fixes #XXXX" here to auto-close the issue(s) that your PR fixes (if any). -->

perigoso commented 2024年11月05日 15:40:05 +01:00 (Migrated from github.com)

Whoops, i missed that this needed rebasing

Whoops, i missed that this needed rebasing

This pull request has changes conflicting with the target branch.