@earl-warren I'm running some exploratory tests since I'm no too sure how to go about testing front-end stuff. Ii wrote a simple stub just to see if I could add new test to the existing test...
@earl-warren , thanks for the tip about uncover.
This is what I'm getting, on what I think are the 2 most significant functions:
$ uncover ./code-cover UserCanBeAssigned
total: ...
Test coverage for the entire issues package is now at 46.5% on this branch
$ ./run-test-coverage.sh
Running go test with -cover -tags 'sqlite sqlite_unlock_notify'...
ok code.gitea.io/...
Hi @fnetX,
No worries about the delay.
I have fixed the conflict.
If this can be merged as is, then maybe you can assign #3502 to me (post-merge of this pr it should then be possible :)...
Hi @fnetX, I have fixed the conflict.
Yes, I can access the staging area, and I can now assign in there. Thank you @fnetX .
I ran some basic tests on https://staging.codeberg.org/forgejo/forgejo/issues/1627
*** Start of test...
Hi @fnetX,
Thank you for pointing out the staging instance. I've logged in as me (could not get in as forgejo somehow) and created a dummy issue. But even as the issue poster I do not seem to...
The comments have been taken on board and I've modified a few bits. But before doing any bigger changes, eg splitting the 'big' function. I'd like this to be used/tested, to see if the UI and the...
Is this better?
// first check that the user has not been blocked by someone that can do so
// for this issue (The repo owner and the issue creator can both block a
// user from being...
One of the issue with this code, I found, was that Xorm does not generate a Union statement correctly (xorm sticks some () around each select, and this i not proper sql.) At least I couldn't make...
I was not aware of private users. There is nothing here that processes private users any differently than 'normal' users.
They can be removed. They are probably worth keeping until everybody is happy with the way this works.
A user that has been added via this new feature (this PR) stays in the list once it has been added once. It can be de-selected (de-assigned), but stays in the list. It can then be picked for...
@fnetX, conflict resolved. This is ready for you to test if you wish to. Cheers.
Hi @fnetX ,
Having removed the WIP, I was expecting the code to be reviewed, so I was simply waiting to get some feed back. I probably got the process wrong.
Having heard from you I got...
A fair bit of investigation has gone into this, mainly on the fomantic-ui dropdown, and how to amend it in a sensible way.
The input field of the dropdown now allows for an input value that is...