avery42/delfin
9
146
Fork
You've already forked delfin
28

Some episode images not loading #151

Open
opened 2024年09月22日 02:50:39 +02:00 by Fisch · 6 comments

Description

For some shows, the episode images aren't loading. From what it seems like, it only happens for specific shows and every episode of those. I checked to make sure the episode images for those shows do exist in Jellyfin.

Screenshots

image

Delfin Version

0.4.6

How did you install Delfin?

Flathub

Operating System/Distro

Fedora Linux 40

### Description For some shows, the episode images aren't loading. From what it seems like, it only happens for specific shows and every episode of those. I checked to make sure the episode images for those shows do exist in Jellyfin. ### Screenshots ![image](/attachments/85e50a8b-95b6-4112-876f-bb14cd37b1f2) ### Delfin Version 0.4.6 ### How did you install Delfin? Flathub ### Operating System/Distro Fedora Linux 40
403 KiB
Contributor
Copy link

#142 normally fix this problem, just need to wait a bit more.

#142 normally fix this problem, just need to wait a bit more.
Author
Copy link

Great. Should I keep this issue open until it's merged to make sure it really does fix the problem?

Great. Should I keep this issue open until it's merged to make sure it really does fix the problem?
Contributor
Copy link

Hello! Unfortunately #142 does not change the logic of which image is selected, so it will not add images where there were none before. The point was just to store the images in a local cache and reduce the number of network queries so that pagination becomes almost instantaneous (after caching).

I also have the same issue with missing images, but after talking with Jellyfin devs it appears the Jellyfin API is finicky and there are no official guidelines on what data from the API a client should use... Feel free to experiment with the API and find out what endpoint the official client uses in what circumstances so that it can be fixed here in Delfin :)

Hello! Unfortunately #142 does not change the logic of which image is selected, so it will not add images where there were none before. The point was just to store the images in a local cache and reduce the number of network queries so that pagination becomes almost instantaneous (after caching). I also have the same issue with missing images, but after talking with Jellyfin devs it appears the Jellyfin API is finicky and there are no official guidelines on what data from the API a client should use... Feel free to experiment with the API and find out what endpoint the official client uses in what circumstances so that it can be fixed here in Delfin :)
Author
Copy link

I only saw your reply now but if I have some time, I might take a look at it

I only saw your reply now but if I have some time, I might take a look at it

This issue still persists

This issue still persists

I'm pretty sure I've narrowed this down, for me it's only happening to episodes with 4:3 thumbnails (possibly any non 16:9 thumbnails). I can see the logic for the episode list on the page for the show forces everything to 1:1 and doesn't have this issue.

I'm pretty sure I've narrowed this down, for me it's only happening to episodes with 4:3 thumbnails (possibly any non 16:9 thumbnails). I can see the logic for the episode list on the page for the show forces everything to 1:1 and doesn't have this issue.
Sign in to join this conversation.
No Branch/Tag specified
main
weblate-delfin-shared
quick-connect-check-enabled
132-deinterlacing
gst
windows
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.0
v0.2.1
v0.2.0
v0.1.0
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Needs Design
Packaging/AUR
Issue with the AUR package
Packaging/Flatpak
Issue with the Flatpak
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Upstream
Issue with a package or library we use that can't be fixed independently
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
avery42/delfin#151
Reference in a new issue
avery42/delfin
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?