Implement image cache on disk #142

selfhoster1312 commented 2024年08月19日 23:13:34 +02:00

This is an initial implementation for #13

TODO:

• refresh cache some time ?
• add documentation
• find ergonomic ApiClient::get_(..)/get_(..)_url scheme
• remove last reqwest::get usage
• (削除) figure out if ImageCache builder should use std::fs:, tokio::fs, glib stuff? (削除ここまで)

Shit is fast now 😎

This is an initial implementation for #13 TODO: - [x] refresh cache some time ? - [x] add documentation - [x] find ergonomic ApiClient::get_(..)/get_(..)_url scheme - [x] remove last reqwest::get usage - ~~figure out if ImageCache builder should use std::fs:, tokio::fs, glib stuff?~~ Shit is fast now 😎

selfhoster1312 commented 2024年08月22日 12:21:39 +02:00

So after talking with Jellyfin devs in #jellyfin-dev on libera.chat, it appears that the item returned from the API knows whether there is an image or not via the "image tags". That will allow us to:

• avoid querying a missing image (404)
• refresh the cache when needed because the image tag changed

So after talking with Jellyfin devs in #jellyfin-dev on libera.chat, it appears that the item returned from the API knows whether there is an image or not via the "image tags". That will allow us to: - avoid querying a missing image (404) - refresh the cache when needed because the image tag changed

selfhoster1312 commented 2024年08月22日 16:49:09 +02:00

So i went with this for the moment, where we query an image using an ImageId (generated from BaseItemDto in API response) and some ImageParams. The id in the ImageId doesn't have to be that of the original item, because it can be a parent item's ID in some cases.

If we ever realize that the Jellyfin API does funky things we may want to add an orig_id in the ImageId struct to keep track of what API response produced an invalid entry, but for the moment it should do the trick.

I still should rewrite EpisodeThumbnail and NextUp who still call reqwest manually, and it should be ready for review. I'll also try to make the jellyfin_api::cache module smaller and more tidy... it grew somewhat unexpectedly in size over the past days.

So i went with this for the moment, where we query an image using an `ImageId` (generated from `BaseItemDto` in API response) and some `ImageParams`. The id in the `ImageId` doesn't have to be that of the original item, because it can be a parent item's ID in some cases. If we ever realize that the Jellyfin API does funky things we may want to add an `orig_id` in the `ImageId` struct to keep track of what API response produced an invalid entry, but for the moment it should do the trick. I still should rewrite `EpisodeThumbnail` and `NextUp` who still call reqwest manually, and it should be ready for review. I'll also try to make the `jellyfin_api::cache` module smaller and more tidy... it grew somewhat unexpectedly in size over the past days.

selfhoster1312 commented 2024年08月22日 18:17:02 +02:00

Ready for review 👍

Ready for review 👍

M3t0r commented 2024年11月30日 08:09:30 +01:00

@avery42 @selfhoster1312 Is there a chance this will get worked on / merged? I have the media on a NAS with rather high latency, so while navigating my Jellyfin instance, waiting for the images to load (bundled with the 24 items per page and missing sorting feature) is the slowest part of my whole experience. This would solve that.

@avery42 @selfhoster1312 Is there a chance this will get worked on / merged? I have the media on a NAS with rather high latency, so while navigating my Jellyfin instance, waiting for the images to load (bundled with the 24 items per page and missing sorting feature) is the slowest part of my whole experience. This would solve that.

avery42 commented 2024年12月03日 04:09:54 +01:00

@M3t0r @selfhoster1312 Sorry for the delay, unfortunately I haven't had much time to work on this lately. I plan on reviewing this soon, it should be in the next release.

@M3t0r @selfhoster1312 Sorry for the delay, unfortunately I haven't had much time to work on this lately. I plan on reviewing this soon, it should be in the next release.

kudos commented 2025年04月25日 11:28:20 +02:00

There's a strange behaviour with episode images vs the main branch. Is this expected?

There's a strange behaviour with episode images vs the main branch. Is this expected?

This pull request can be merged automatically.

You are not authorized to merge this pull request.