4
92
Fork
You've already forked zg
23

Miscellaneous fixes: remove dead code and fix comments #76

Closed
jacobsandlund wants to merge 1 commit from jacobsandlund/zg:misc into master
pull from: jacobsandlund/zg:misc
merge into: atman:master
atman:master
atman:no-allocation
Contributor
Copy link

This PR removes a line of code from codegen/upper.zig that wasn't doing anything, and fixes a couple of comments.

This PR removes a line of code from `codegen/upper.zig` that wasn't doing anything, and fixes a couple of comments.
@ -37,8 +37,6 @@ pub fn main() !void {
switch(i){
0=>cp=trystd.fmt.parseInt(i24,field,16),
2=>if(line[0]=='<')continue:lines,
Author
Contributor
Copy link

This line wasn't doing anything, as line[0] is never < in data/unicode/UnicodeData.txt. Maybe this was intended to check for field[0]? but also column index 2 (third column) never has < either. Column index 1 (second column) does contain < for things like <control>, but those also don't have the upper case equivalent in column index 12, so I think this line of code is simply not needed.

This line wasn't doing anything, as `line[0]` is never `<` in `data/unicode/UnicodeData.txt`. Maybe this was intended to check for `field[0]`? but also column index 2 (third column) never has `<` either. Column index 1 (second column) does contain `<` for things like `<control>`, but those also don't have the upper case equivalent in column index 12, so I think this line of code is simply not needed.
Owner
Copy link

I honestly don't know if this one got incorporated or just no longer applies. Either way, thanks!

I honestly don't know if this one got incorporated or just no longer applies. Either way, thanks!
atman closed this pull request 2026年04月21日 18:36:38 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
atman/zg!76
Reference in a new issue
atman/zg
No description provided.
Delete branch "jacobsandlund/zg:misc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?