Add --parser arg #21

Arnau478 (Migrated from github.com) commented 2024年05月11日 16:35:17 +02:00

The parser list should be comptime-generated

The parser list should be comptime-generated

Arnau478 (Migrated from github.com) commented 2024年05月11日 16:44:22 +02:00

Maybe it's just me, but I try to avoid OOM panics. I think panics should only be used in two scenarios:

• Internal program crashes that shouldn't be possible in theory
• When not in main's stack frame (rare), e.g. interrupt or syscall handler of some kind, code jumped to...

Running out of memory is definitely a state external to the program and should be handled gracefully.

Maybe it's just me, but I try to avoid OOM panics. I think panics should only be used in two scenarios: - Internal program crashes that shouldn't be possible in theory - When not in main's stack frame (rare), e.g. interrupt or syscall handler of some kind, code jumped to... Running out of memory is definitely a state external to the program and should be handled gracefully.

Arnau478 (Migrated from github.com) commented 2024年05月11日 16:53:22 +02:00

We should still run matches() and print an error if it's not an appropriate file when a parser is explicitly specified. Otherwise, garbage will be printed.

We should still run matches() and print an error if it's not an appropriate file when a parser is explicitly specified. Otherwise, garbage will be printed.

Arnau478 (Migrated from github.com) commented 2024年05月12日 10:01:58 +02:00

This will panic. Could you add an else statement that prints an error?

This will panic. Could you add an else statement that prints an error?

Reokodoku (Migrated from github.com) commented 2024年05月12日 10:36:47 +02:00

Is something like this okay? Maybe we can print it in red (if color support is enabled).

diff --git a/src/parser.zig b/src/parser.zig
index da609ba..b41498c 100644
--- a/src/parser.zig
+++ b/src/parser.zig
@@ -21,6 +21,9 @@ pub fn getColors(allocator: std.mem.Allocator, reader: std.io.AnyReader, options
 if (parser.matches(data)) {
 parser.getColors(colors, data);
 return colors;
+ } else {
+ std.debug.print("The specified parser doesn't match the file format!\n", .{});
+ std.process.exit(1);
 }
 }
 } else if (parser.matches(data)) {

Is something like this okay? Maybe we can print it in red (if color support is enabled). ```patch diff --git a/src/parser.zig b/src/parser.zig index da609ba..b41498c 100644 --- a/src/parser.zig +++ b/src/parser.zig @@ -21,6 +21,9 @@ pub fn getColors(allocator: std.mem.Allocator, reader: std.io.AnyReader, options if (parser.matches(data)) { parser.getColors(colors, data); return colors; + } else { + std.debug.print("The specified parser doesn't match the file format!\n", .{}); + std.process.exit(1); } } } else if (parser.matches(data)) { ```

Arnau478 (Migrated from github.com) commented 2024年05月12日 10:42:32 +02:00

Yeah, just do that basic print. Maybe wirh an "Error:" prefix. I wanted to unify error reporting, but haven't done so yet. When I do I'll update it :)

Yeah, just do that basic print. Maybe wirh an "Error:" prefix. I wanted to unify error reporting, but haven't done so yet. When I do I'll update it :)