Fix erroneous spd json schema #11

l-x commented 2021年11月10日 12:40:34 +01:00

No description provided.

yarmo commented 2021年11月10日 13:02:16 +01:00

Good catch, thanks for the PR! Would you mind adding an extra 0.1.2 revision to the XML header?

Good catch, thanks for the PR! Would you mind adding an extra `0.1.2` revision to the XML header?

wiktor commented 2021年11月10日 13:07:51 +01:00

That's a good catch! 👍

I wonder in we should have a CI job to extract all JSON fragments and if they're JSON Schema then verify if the Schema is OK. To avoid further issues like these.

@yarmo what do you think?

That's a good catch! 👍 I wonder in we should have a CI job to extract all JSON fragments and if they're JSON Schema then verify if the Schema is OK. To avoid further issues like these. @yarmo what do you think?

l-x commented 2021年11月10日 13:10:01 +01:00

Would you mind adding an extra 0.1.2 revision to the XML header?

Update date too?

> Would you mind adding an extra `0.1.2` revision to the XML header? Update `date` too?

yarmo commented 2021年11月10日 13:11:24 +01:00

@wiktor Given that I am not expecting any more JSON schemas, I think it would be quite the overkill.

I have already written the XML schemas and these should definitely be checked via CI/CD!

@l-x Yes, good thinking! Still getting used to this system :)

@wiktor Given that I am not expecting any more JSON schemas, I think it would be quite the overkill. I have already written the XML schemas and these should definitely be checked via CI/CD! @l-x Yes, good thinking! Still getting used to this system :)

yarmo commented 2021年11月10日 13:14:17 +01:00

@l-x Sorry for the double work. No, the date shouldn't be changed.

@l-x Sorry for the double work. No, the date shouldn't be changed.

l-x commented 2021年11月10日 13:17:50 +01:00

@yarmo Are two commits in one pr okay?

@yarmo Are two commits in one pr okay?

yarmo commented 2021年11月10日 13:21:39 +01:00

@l-x multiple commits are perfectly fine to me. The "merge pull request" button can squash if need be.

Re revision: I meant, add an entire new revision, so that it would be:

 <revision>
 <version>0.1.2</version>
 <date>2021年11月10日</date>
 <remark>Fixed error in JSON schema.</remark>
 </revision>
 <revision>
 <version>0.1.1</version>
 <date>2021年11月09日</date>
 <remark>Fixed minor mistakes.</remark>
 </revision>
 <revision>
 <version>0.1.0</version>
 <date>2021年11月09日</date>
 <remark>Initial version.</remark>
 </revision>

@l-x multiple commits are perfectly fine to me. The "merge pull request" button can squash if need be. Re revision: I meant, add an entire new revision, so that it would be: ``` <revision> <version>0.1.2</version> <date>2021年11月10日</date> <remark>Fixed error in JSON schema.</remark> </revision> <revision> <version>0.1.1</version> <date>2021年11月09日</date> <remark>Fixed minor mistakes.</remark> </revision> <revision> <version>0.1.0</version> <date>2021年11月09日</date> <remark>Initial version.</remark> </revision> ```

l-x commented 2021年11月10日 13:28:50 +01:00

@yarmo My bad, sorry. Still too tired...

@yarmo My bad, sorry. Still too tired...

yarmo commented 2021年11月10日 13:33:11 +01:00

@l-x no worries, thanks a bunch for the PR! The first contribution outside of the people who started this thing, so cause for celebration 🥇

@l-x no worries, thanks a bunch for the PR! The first contribution outside of the people who started this thing, so cause for celebration 🥇

l-x commented 2021年11月10日 13:33:18 +01:00

I guess i screwed the pr -.-.

I should have stayed in bed today 😫

I guess i screwed the pr -.-. I should have stayed in bed today 😫

l-x commented 2021年11月10日 13:36:41 +01:00

@l-x no worries, thanks a bunch for the PR! The first contribution outside of the people who started this thing, so cause for celebration 🥇

🥳 🎆 😆

pr should be ok now

> @l-x no worries, thanks a bunch for the PR! The first contribution outside of the people who started this thing, so cause for celebration 🥇 🥳 🎆 😆 pr should be ok now

yarmo commented 2021年11月10日 13:38:15 +01:00

I really hate myself for being that guy right now, but...

<remark>Fixed Fix json schema error.</remark>

Other than that, perfect!

I really hate myself for being that guy right now, but... ```xml <remark>Fixed Fix json schema error.</remark> ``` Other than that, perfect!

l-x commented 2021年11月10日 13:48:02 +01:00

@yarmo No worries, for my living usually I am that kind of guy. It was just a question of time when this comes back to me... xD

@yarmo No worries, for my living usually I am that kind of guy. It was just a question of time when this comes back to me... xD

yarmo commented 2021年11月10日 13:51:46 +01:00

Looks perfect to me! I'll merge in a bit

Looks perfect to me! I'll merge in a bit