Add overall rip progress bar to content area #92

tduarte commented 2026年05月08日 02:18:01 +02:00

When I first tried to use Laser, I though for a moment that there was no progress indicator because the icons are so subtle. I wanted to make sure this doesn't happen with other users, but also keeps the clean and minimal interface. This PR adds a progress bar to the top of the content area that shows overall ripping progress across all tracks.

• Slides down on rip start, hides on completion / error / cancel
• Advances by 1/n_tracks after each track completes (sequential rips → monotonic)
• No labels or percentage — just a clean bar
• Square corners via a small .rip-progress CSS rule

Test plan

• Insert a CD, click Rip → bar appears at top, fills monotonically, hides on finish
• Stop rip mid-way → bar hides immediately
• Trigger an error path → bar hides via the unified _on_ripper_finished
• In offline mode, banner + progress bar coexist cleanly

When I first tried to use Laser, I though for a moment that there was no progress indicator because the icons are so subtle. I wanted to make sure this doesn't happen with other users, but also keeps the clean and minimal interface. This PR adds a progress bar to the top of the content area that shows overall ripping progress across all tracks. - Slides down on rip start, hides on completion / error / cancel - Advances by 1/n_tracks after each track completes (sequential rips → monotonic) - No labels or percentage — just a clean bar - Square corners via a small .rip-progress CSS rule **Test plan** - Insert a CD, click Rip → bar appears at top, fills monotonically, hides on finish - Stop rip mid-way → bar hides immediately - Trigger an error path → bar hides via the unified _on_ripper_finished - In offline mode, banner + progress bar coexist cleanly

andreasknoben commented 2026年05月08日 10:38:27 +02:00

Hi, thank you so much for your contribution! I agree with you that a progress bar would be a better way to indicate progress.

However, to achieve this look, perhaps it's better to use the "built-in" thin progress bar. The documentation says this requires a GtkOverlay (presumably instead of the Revealer you've used now).

I can have a look at this if you want, to integrate it with your changes; but let me know if you'd prefer to do so yourself.

Thanks again for the PR!

Hi, thank you so much for your contribution! I agree with you that a progress bar would be a better way to indicate progress. However, to achieve this look, perhaps it's better to use the ["built-in" thin progress bar](https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#progress-bars). The documentation says this requires a GtkOverlay (presumably instead of the Revealer you've used now). I can have a look at this if you want, to integrate it with your changes; but let me know if you'd prefer to do so yourself. Thanks again for the PR!

tduarte commented 2026年05月09日 01:32:44 +02:00

Hi @andreasknoben ! I knew there was something like that on Adwaita but when I was working on this I don't know why, I couldn't find it! I can update the PR, no problem! Thank you for flagging!

Hi @andreasknoben ! I knew there was something like that on Adwaita but when I was working on this I don't know why, I couldn't find it! I can update the PR, no problem! Thank you for flagging!

tduarte commented 2026年05月09日 01:49:54 +02:00

Just to let you know, when testing the UI I got an error after the last song, I can't see how this change would affect that behavior, so you might want to test ripping another CD. I will try it again with another one later too. Update pushed though!

Just to let you know, when testing the UI I got an error after the last song, I can't see how this change would affect that behavior, so you might want to test ripping another CD. I will try it again with another one later too. Update pushed though!

andreasknoben commented 2026年05月09日 10:28:06 +02:00

Hi @tduarte , thank you for implementing the OSD-style progress bar! This looks good - I'll merge it. Is it okay if I list you under contributors, and would it be okay as (tduarte, https://codeberg.org/tduarte)?

I've been updating the ripping logic ever so slightly to accommodate CDs with non-audio tracks. I'll merge your code, then merge that fix (and adapt the progress bar logic slightly to fit it), and please give it a try after that. If you still get the error, it'd be great if you could open an issue!

Hi @tduarte , thank you for implementing the OSD-style progress bar! This looks good - I'll merge it. Is it okay if I list you under contributors, and would it be okay as (tduarte, https://codeberg.org/tduarte)? I've been updating the ripping logic ever so slightly to accommodate CDs with non-audio tracks. I'll merge your code, then merge that fix (and adapt the progress bar logic slightly to fit it), and please give it a try after that. If you still get the error, it'd be great if you could open an issue!

andreasknoben commented 2026年05月09日 10:40:43 +02:00

@tduarte The latest develop build should include these changes. Thanks again for your contribution!

@tduarte The latest `develop` build should include these changes. Thanks again for your contribution!

tduarte commented 2026年05月09日 19:04:21 +02:00

@andreasknoben wrote in #92 (comment):

Hi @tduarte , thank you for implementing the OSD-style progress bar! This looks good - I'll merge it. Is it okay if I list you under contributors, and would it be okay as (tduarte, https://codeberg.org/tduarte)?

I've been updating the ripping logic ever so slightly to accommodate CDs with non-audio tracks. I'll merge your code, then merge that fix (and adapt the progress bar logic slightly to fit it), and please give it a try after that. If you still get the error, it'd be great if you could open an issue!

No, thank YOU! Great project!

It can be! I actually registered here because of this PR so I don't use it too much. But I also have a GNOME Gitlab.

Thanks for merging! Excited about this project, especially now that I have been buying more and more CDs to make my own collection.

@andreasknoben wrote in https://codeberg.org/andreasknoben/Laser/pulls/92#issuecomment-14541912: > Hi @tduarte , thank you for implementing the OSD-style progress bar! This looks good - I'll merge it. Is it okay if I list you under contributors, and would it be okay as (tduarte, https://codeberg.org/tduarte)? > > I've been updating the ripping logic ever so slightly to accommodate CDs with non-audio tracks. I'll merge your code, then merge that fix (and adapt the progress bar logic slightly to fit it), and please give it a try after that. If you still get the error, it'd be great if you could open an issue! No, thank YOU! Great project! It can be! I actually registered here because of this PR so I don't use it too much. But I also have a [GNOME Gitlab](https://gitlab.gnome.org/tduarte). Thanks for merging! Excited about this project, especially now that I have been buying more and more CDs to make my own collection.