1
3
Fork
You've already forked koa
1

feat: implement basic colorschemes, syntax highlighting through tree-sitter #12

Merged
amartin merged 7 commits from push-xwmloxqpnytu into master 2025年09月12日 14:36:25 +02:00

Performance is terrible for now in debug builds and I guess it also affects production builds, I'll address the performance issues right in this PR. Expect horrendous input lag for now until there's a perf commit in the PR branch.

Implementing syntax highlighting and colorschemes somehow fucked up:

  1. Cursor coloring (already fixed)
  2. Line:column display in statusline (I don't think this is related but I began seeing this bug right after the changes for some reason?)

2. For some reason, I've got trolled by Zig and my own code, as the cursor position in the statusbar is rendering just fine on release builds but it won't render in debugging builds for some reason beyond my comprehension so YAGNI as long as it works in release.

Performance is terrible for now in debug builds and I guess it also affects production builds, I'll address the performance issues right in this PR. Expect horrendous input lag for now until there's a perf commit in the PR branch. Implementing syntax highlighting and colorschemes somehow fucked up: 1. Cursor coloring (already fixed) 2. Line:column display in statusline (I don't think this is related but I began seeing this bug right after the changes for some reason?) <sup>2</sup>. For some reason, I've got trolled by Zig and my own code, as the cursor position in the statusbar is rendering just fine on release builds but it won't render in debugging builds for some reason beyond my comprehension so YAGNI as long as it works in release.
amartin force-pushed push-xwmloxqpnytu from 1ba787221b to 6fbb4d14b9 2025年09月11日 20:44:48 +02:00 Compare 
This should fix the cursor shape not being shown as before, addressing the regression
This should greatly improve the editor responsiveness, as it won't need to re-parse nor re-apply syntax highlighting unless the buffer contents have been modified and avoid overhead
amartin changed title from (削除) WIP: feat: implement basic colorschemes, syntax highlighting through tree-sitter (削除ここまで) to feat: implement basic colorschemes, syntax highlighting through tree-sitter 2025年09月11日 22:44:42 +02:00
amartin changed title from (削除) feat: implement basic colorschemes, syntax highlighting through tree-sitter (削除ここまで) to WIP: feat: implement basic colorschemes, syntax highlighting through tree-sitter 2025年09月12日 13:58:55 +02:00
Author
Owner
Copy link

I'm marking the PR as WIP again as I'm still doing some performance improvements and trying to spot any further regression before shipping the changes. I've forgotten to add the cache refresh and dirty tracking to several parts of the Janet runtime, so I'm fixing them right now.

I'm marking the PR as WIP again as I'm still doing some performance improvements and trying to spot any further regression before shipping the changes. I've forgotten to add the cache refresh and dirty tracking to several parts of the Janet runtime, so I'm fixing them right now.
amartin changed title from (削除) WIP: feat: implement basic colorschemes, syntax highlighting through tree-sitter (削除ここまで) to feat: implement basic colorschemes, syntax highlighting through tree-sitter 2025年09月12日 14:31:47 +02:00
amartin force-pushed push-xwmloxqpnytu from e1ece09a8f to d1c830c8e8 2025年09月12日 14:32:42 +02:00 Compare
Author
Owner
Copy link

Everything seems to be working as expected now, merging this.

Everything seems to be working as expected now, merging this.
amartin force-pushed push-xwmloxqpnytu from d1c830c8e8 to d178e8dc53 2025年09月12日 14:36:04 +02:00 Compare
amartin deleted branch push-xwmloxqpnytu 2025年09月12日 14:36:25 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat
Breaking
 Breaking change that won't be backward compatible
Kind
Bug
 Something is not working
Kind
Documentation
 Documentation changes
Kind
Enhancement
 Improve existing functionality
Kind
Feature
 New functionality
Kind
Security
 This is security issue
Kind
Testing
 Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Priority
Undefined
 The priority has to be defined
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amartin/koa!12
Reference in a new issue
amartin/koa
No description provided.
Delete branch "push-xwmloxqpnytu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?