12
113
Fork
You've already forked django-allauth
149

fix: improve get_adapter typing #4688

Merged
pennersr merged 1 commit from akx/django-allauth:emtypen into main 2026年03月05日 16:24:42 +01:00
Contributor
Copy link

Improves the typing for allauth.account.adapter.get_adapter (it may return a subtype of DefaultAccountAdapter), and adds the same to other get_adapters.

Improves the typing for `allauth.account.adapter.get_adapter` (it may return a subtype of `DefaultAccountAdapter`), and adds the same to other `get_adapter`s.
akx changed title from (削除) fix: improve get_adapter typing (削除ここまで) to WIP: fix: improve get_adapter typing 2026年03月04日 17:51:19 +01:00
akx force-pushed emtypen from 7429c0f01a
Some checks are pending
ci/woodpecker/pr/woodpecker/1 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/2 Pipeline is pending approval
to 86db538d5b
Some checks are pending
ci/woodpecker/pr/woodpecker/1 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/2 Pipeline is pending approval
2026年03月04日 17:53:15 +01:00 Compare
akx changed title from (削除) WIP: fix: improve get_adapter typing (削除ここまで) to fix: improve get_adapter typing 2026年03月04日 17:53:29 +01:00

This causes various errors, a.o.:

allauth/account/internal/flows/password_reset.py:42: error: Need type annotation for "adapter" [var-annotated]
allauth/account/internal/flows/manage_email.py:17: error: Need type annotation for "adapter" [var-annotated]
allauth/account/internal/flows/manage_email.py:26: error: Need type annotation for "adapter" [var-annotated]
allauth/account/internal/flows/manage_email.py:103: error: Need type annotation for "adapter" [var-annotated]
allauth/account/internal/flows/manage_email.py:214: error: Need type annotation for "adapter" [var-annotated]
allauth/account/internal/flows/email_verification.py:305: error: Need type annotation for "send" [var-annotated]

Will need to revert.

This causes various errors, a.o.: ``` allauth/account/internal/flows/password_reset.py:42: error: Need type annotation for "adapter" [var-annotated] allauth/account/internal/flows/manage_email.py:17: error: Need type annotation for "adapter" [var-annotated] allauth/account/internal/flows/manage_email.py:26: error: Need type annotation for "adapter" [var-annotated] allauth/account/internal/flows/manage_email.py:103: error: Need type annotation for "adapter" [var-annotated] allauth/account/internal/flows/manage_email.py:214: error: Need type annotation for "adapter" [var-annotated] allauth/account/internal/flows/email_verification.py:305: error: Need type annotation for "send" [var-annotated] ``` Will need to revert.
Author
Contributor
Copy link

Those type check errors within allauth or in downstream projects?

EDIT: Ah, I see now. Sorry for the noise!

Those type check errors within allauth or in downstream projects? **EDIT:** Ah, I see now. Sorry for the noise!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
allauth/django-allauth!4688
Reference in a new issue
allauth/django-allauth
No description provided.
Delete branch "akx/django-allauth:emtypen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?