Aaruni Kaushik - Codeberg.org

Reusing the group prav@conference.prav.app

See above

Is not "hijack" too strong a word for what might be a truly innocent attempt at setting a username?

Is "undocumented" the right word here? Also see the above note about "hijack"

Thanks for the work @thecodephilic-guy . Some mostly minor comments from having read the code.

number will most likely need to be changed to phoneNumber to be consistent with changes suggested above.

Sorry, my regx is a bit rusty. Can you explain what this line is matching against ? For future newcomers to the code, could you also add it as a comment in the code ?

This looks like we are parsing only German numbers? Is my understanding correct? If so, is there a reason to enforce this?

Its nicer to stick to convention, and use phoneNumber instead of phonenumber.

For consistency with the codebase, I would like to see :phoneNumber be used instead of :number.

Instead of saying "parameters.size() lesser than 2 or parameters.size() greater than 3", would it not be more clear to say "not(parameters.size() equals 2 or parameters.size() equals 3)" ?

Idiomatically, should com.google.i18n.phonenumbers.Phonenumber.PhoneNumber not instead be an import ?

While ternary operator is technically not wrong, I always like code to be a bit more verbose. Maybe consider having this in an if/else block instead?

@untrusem I specifically asked @thecodephilic-guy not to look at the existing PRs. #17 is more or less garbage. #27 was just me trying to rebase #17 onto the latest master and trying to see if I...

It is possible to have the badges rendered by embedding the image https://gatus.edufor.me/api/v1/endpoints/prav_prav-website/uptimes/30d/badge.svg

This is a workaround, but I would not call it a "fix". The fix would be to not have html inside markdown.

Sorry if I'm being silly, but isn't "four copies ... in original" self contradictory ?