Wuzzy/pride_flags
2
8
Fork
You've already forked pride_flags
6

Add compatibility with Mineclone2 + French translation #5

Closed
Z-Master wants to merge 6 commits from Z-Master/pride_flags:master into master
pull from: Z-Master/pride_flags:master
merge into: Wuzzy:master
Wuzzy:master
Wuzzy:all_wuzzy_updates
Wuzzy:stuff
Wuzzy:newflags
Wuzzy:hidden
First-time contributor
Copy link

Changed a few things to make it compatible with Mineclone2. (Recipes with mineclone nodes + pickable by hand)
Also added a french translation.
Tested on my Mineclone2 server, found no issue.

Changed a few things to make it compatible with Mineclone2. (Recipes with mineclone nodes + pickable by hand) Also added a french translation. Tested on my Mineclone2 server, found no issue.
Owner
Copy link

mineclone2 is not a valid dependency tho. The depends line is for mod names only.

`mineclone2` is not a valid dependency tho. The `depends` line is for mod names only.
Author
First-time contributor
Copy link

Should be good now!

Should be good now!
Owner
Copy link

I disagree with adding the handy group (or is the node node diggable at all without it?).

Also, the iron and wool variables are no longer local, apparently.

Sorry for not noticing this earlier.

PR looks fine otherwise.

I disagree with adding the `handy` group (or is the node node diggable at all without it?). Also, the `iron` and `wool` variables are no longer local, apparently. Sorry for not noticing this earlier. PR looks fine otherwise.
Author
First-time contributor
Copy link

Hello,

Yes, you need one specific mcl group as mentioned here :

https://git.minetest.land/MineClone2/MineClone2/src/branch/master/GROUPS.md

If there is none, then the object is not pickable in Mineclone 2.

For the local variable, I don't understand the issue. I've added the local variables to the script, do they need to be not local?

Hello, Yes, you need one specific mcl group as mentioned here : https://git.minetest.land/MineClone2/MineClone2/src/branch/master/GROUPS.md If there is none, then the object is not pickable in Mineclone 2. For the local variable, I don't understand the issue. I've added the local variables to the script, do they need to be not local?
Owner
Copy link

I have decided to include the French translation but reject the code.

Reason: I don't like how compability is implemented. Flag pole should not be diggable by hand. Needs pickaxe.

I have decided to include the French translation but reject the code. Reason: I don't like how compability is implemented. Flag pole should not be diggable by hand. Needs pickaxe.
Wuzzy closed this pull request 2023年04月20日 17:49:24 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Wuzzy/pride_flags!5
Reference in a new issue
Wuzzy/pride_flags
No description provided.
Delete branch "Z-Master/pride_flags:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?