use the formspecs to select the flag if the flags count greater than 40 #3

riceball commented 2022年09月08日 09:06:00 +02:00

I've add all country flags: https://github.com/snowyu/minetest-country_flags

It's too many to select one. So I added this.

I've add all country flags: https://github.com/snowyu/minetest-country_flags It's too many to select one. So I added this.

Wuzzy commented 2022年09月10日 13:51:13 +02:00

Thanks. I also worked on a branch to do something like that, but lost interest.

I am not happy with your changes for now. Several problems:

• The flag icon is weirdly cut-off in the flag formspec
• Only works if there are 40 flags (why this arbitrary number?)
• Does not work for flags that were already placed in the world (no LBM?)

Thanks. I also worked on a branch to do something like that, but lost interest. I am not happy with your changes for now. Several problems: * The flag icon is weirdly cut-off in the flag formspec * Only works if there are 40 flags (why this arbitrary number?) * Does not work for flags that were already placed in the world (no LBM?)

riceball commented 2022年09月12日 16:14:20 +02:00

I've just tried to solve the problem too many flags to choose from.

It's just a start to solve the problem. It's enough for my kids. After all minetest is just a teaching aid(toy) for children, very good.

So If have a better implementation with more free time, that's very perfect.
I am a new bie for formspec or lua.

The flag icon is weirdly cut-off in the flag formspec

It seems a bug: Images in tablecolumn are not scaled

Only works if there are 40 flags (why this arbitrary number?)

Only works if there are greater than 40 flags.
Keeping the previous approach is fine if there aren't too many flags.
The 40 flags is roughly estimated that the previous flag will not exceed.

Does not work for flags that were already placed in the world (no LBM?)

Maybe LBM should be a switch in settingtypes to reduce the CPU overhead.

I've just tried to solve the problem too many flags to choose from. It's just a start to solve the problem. It's enough for my kids. After all minetest is just a teaching aid(toy) for children, very good. So If have a better implementation with more free time, that's very perfect. I am a new bie for formspec or lua. > The flag icon is weirdly cut-off in the flag formspec It seems a bug: [Images in tablecolumn are not scaled](https://github.com/minetest/minetest/issues/3403) > Only works if there are 40 flags (why this arbitrary number?) Only works if there are greater than 40 flags. Keeping the previous approach is fine if there aren't too many flags. The 40 flags is roughly estimated that the previous flag will not exceed. > Does not work for flags that were already placed in the world (no LBM?) Maybe LBM should be a switch in settingtypes to reduce the CPU overhead.

Wuzzy commented 2022年09月12日 22:46:14 +02:00

Yeah, sorry, if the problems are not resolved, no merge. And I don't care enough about this mod to do the work myself.

So if there is no flag preview for the list possible, probably just remove it. It's better to have no feature than a broken feature. Besides, the player can see the flag in the 3D world anyway.

As for LBMs, this is not really a CPU concern as they are only executed at loading time. Once loaded, they don't do anything.

Conditions for merging:

• Fix or remove the flag preview in the list
• Fix the menu not appearing for flags that were already placed
• No bugs

Yeah, sorry, if the problems are not resolved, no merge. And I don't care enough about this mod to do the work myself. So if there is no flag preview for the list possible, probably just remove it. It's better to have no feature than a broken feature. Besides, the player can see the flag in the 3D world anyway. As for LBMs, this is not really a CPU concern as they are only executed at loading time. Once loaded, they don't do anything. Conditions for merging: * Fix or remove the flag preview in the list * Fix the menu not appearing for flags that were already placed * No bugs

Wuzzy commented 2022年09月29日 19:25:17 +02:00

If there is no response or change in about 30 days, I consider closing this PR as rejected.

If there is no response or change in about 30 days, I consider closing this PR as rejected.