Crafting recipes don't work if they use an alias of an item #258

Skivling commented 2025年07月20日 01:59:17 +02:00

One of the RePixture crafting recipes for my mod wasn't working, but it was fixed after replacing the alias with the new itemstring.

This is the original recipe: (d. and i. tables are defined separately)

d.tardis = "drwho_tardis:tardis"
d.arton_crystal = "drwho_tardis:arton_crystal" -- this item
i.block_steel 		= "rp_default:block_steel"
d.circuitry_board = "drwho_tardis:circuitry_board"
 crafting.register_craft({
 output = d.tardis,
 items = {
 i.block_steel.." 6",
 d.arton_crystal, --
 d.spacetime,
 d.circuitry_board.." 1",
 }
 }) 

I previously renamed the arton crystal to artron crystal, and there is an alias:

core.register_alias("drwho_tardis:arton_crystal", "drwho_tardis:artron_crystal")

But I hadn't remembered to replace the reference in the d. table with the new itemstring. It worked in MTG so I didn't bat an eye. So the crafting recipes were being registered with an alias and not the actual itemstring - and in RePixture this meant the crafting didn't work.
The recipe still displayed in the menu with the correct items, but putting in those items did not craft it. I suspect that there is a place in the code that isn't checking against aliases.

When I replaced the value:
d.arton_crystal = "drwho_tardis:artron_crystal"
the crafting worked properly.

One of the RePixture crafting recipes for my mod wasn't working, but it was fixed after replacing the alias with the new itemstring. This is the original recipe: (d. and i. tables are defined separately) ```lua d.tardis = "drwho_tardis:tardis" d.arton_crystal = "drwho_tardis:arton_crystal" -- this item i.block_steel = "rp_default:block_steel" d.circuitry_board = "drwho_tardis:circuitry_board" crafting.register_craft({ output = d.tardis, items = { i.block_steel.." 6", d.arton_crystal, -- d.spacetime, d.circuitry_board.." 1", } }) ``` I previously renamed the arton crystal to artron crystal, and there is an alias: ```lua core.register_alias("drwho_tardis:arton_crystal", "drwho_tardis:artron_crystal") ``` But I hadn't remembered to replace the reference in the `d.` table with the new itemstring. It worked in MTG so I didn't bat an eye. So the crafting recipes were being registered with an alias and not the actual itemstring - and in RePixture this meant the crafting didn't work. The recipe still displayed in the menu with the correct items, but putting in those items did not craft it. I suspect that there is a place in the code that isn't checking against aliases. When I replaced the value: `d.arton_crystal = "drwho_tardis:artron_crystal"` the crafting worked properly.

Wuzzy commented 2025年07月20日 11:37:53 +02:00

Yes, you're right, the crafting mod doesn’t look at aliases. This is a bug, I just forgot about it.

Yes, you're right, the crafting mod doesn’t look at aliases. This is a bug, I just forgot about it.

Wuzzy commented 2026年01月22日 13:03:59 +01:00

Strange. I cannot reproduce this. I used your example to write a minimal test mod called drwho_tardis with the following code:

init.lua:

core.register_craftitem("drwho_tardis:tardis", {
	description = "TARDIS",
	-- dummy texture
	inventory_image = "[fill:16x16:#0000FF",
})
core.register_craftitem("drwho_tardis:artron_crystal", {
	description = "Art(r)on Crystal",
	-- dummy texture
	inventory_image = "[fill:16x16:#FF00FF",
})
core.register_craftitem("drwho_tardis:circuitry_board", {
	description = "Circuitry Board",
	-- dummy texture
	inventory_image = "[fill:16x16:#888888",
})
core.register_craftitem("drwho_tardis:spacetime", {
	description = "Spacetime",
	-- dummy texture
	inventory_image = "[fill:16x16:#000000",
})
core.register_alias("drwho_tardis:arton_crystal", "drwho_tardis:artron_crystal")
local d = {}
local i = {}
d.tardis = "drwho_tardis:tardis"
d.arton_crystal = "drwho_tardis:arton_crystal" -- this item
i.block_steel = "rp_default:block_steel"
d.circuitry_board = "drwho_tardis:circuitry_board"
d.spacetime = "drwho_tardis:spacetime" --<< was missing in your example
crafting.register_craft({
	output = d.tardis,
	items = {
		i.block_steel.." 6",
		d.arton_crystal, --
		d.spacetime,
		d.circuitry_board.." 1",
	}
})

mod.conf:

name = drwho_tardis
depends = rp_crafting

If I run this code, the crafting recipe appears correctly in the crafting guide and I can also craft it.

Please test if you can still reproduce this bug in Repixture cee90257ca and Luanti 5.15.0.

Strange. I cannot reproduce this. I used your example to write a minimal test mod called `drwho_tardis` with the following code: init.lua: ``` core.register_craftitem("drwho_tardis:tardis", { description = "TARDIS", -- dummy texture inventory_image = "[fill:16x16:#0000FF", }) core.register_craftitem("drwho_tardis:artron_crystal", { description = "Art(r)on Crystal", -- dummy texture inventory_image = "[fill:16x16:#FF00FF", }) core.register_craftitem("drwho_tardis:circuitry_board", { description = "Circuitry Board", -- dummy texture inventory_image = "[fill:16x16:#888888", }) core.register_craftitem("drwho_tardis:spacetime", { description = "Spacetime", -- dummy texture inventory_image = "[fill:16x16:#000000", }) core.register_alias("drwho_tardis:arton_crystal", "drwho_tardis:artron_crystal") local d = {} local i = {} d.tardis = "drwho_tardis:tardis" d.arton_crystal = "drwho_tardis:arton_crystal" -- this item i.block_steel = "rp_default:block_steel" d.circuitry_board = "drwho_tardis:circuitry_board" d.spacetime = "drwho_tardis:spacetime" --<< was missing in your example crafting.register_craft({ output = d.tardis, items = { i.block_steel.." 6", d.arton_crystal, -- d.spacetime, d.circuitry_board.." 1", } }) ``` mod.conf: ``` name = drwho_tardis depends = rp_crafting ``` If I run this code, the crafting recipe appears correctly in the crafting guide and I can also craft it. Please test if you can still reproduce this bug in Repixture cee90257ca99e9018f6b644b1f260b81d784d031 and Luanti 5.15.0.

Wuzzy commented 2026年02月06日 20:03:52 +01:00

Since I cannot reproduce this bug, and there is no response, I close this issue for now. It could be that changes to the code in Luanti might have "accidentally" fixed the bug.

When you (or anyone else) have new information about this, please post and I will re-open if needed.

Since I cannot reproduce this bug, and there is no response, I close this issue for now. It could be that changes to the code in Luanti might have "accidentally" fixed the bug. When you (or anyone else) have new information about this, please post and I will re-open if needed.