More skin colors (different hue?) #183

Wuzzy commented 2024年05月25日 16:59:57 +02:00

The current skins colors only differ in brightness but not hue.
One player has complained about that the current colors do not represent them.

I wonder how to add more skin colors without bloating the UI.

The current skins colors only differ in brightness but not hue. One player has complained about that the current colors do not represent them. I wonder how to add more skin colors without bloating the UI.

Wuzzy commented 2024年05月27日 13:13:57 +02:00

shaft wrote:

https://en.wikipedia.org/wiki/Von_Luschan's_chromatic_scale#/media/File:Imprecise-Biasutti-map.jpg

https://upload.wikimedia.org/wikipedia/commons/3/3c/Felix_von_Luschan_Skin_Color_chart.svg

Here's a reference of skin color distribution. As you can see most countries' native skin colors in Europe and Asia are below 14 on the scale. Just pick some (10 like you already have is probably enough, just take every fifth) and use an imagebutton and [fill:

Bumping from 10 to 14 skins sounds OK. I wonder if I could get away by just adding a few lighter levels than the current brightest one without changing the hue in order to keep the symmetry. Another option would be to change the hue of ALL skins. Meh.

[fill won't work, all the skin colors are stored textures and NOT auto-generated (this is by design as this allows maximum freedom for texture pack authors). But drawing new textures is easy. The hard part is picking good colors.

Currently, the 10 skin colors have been carefully chosen to have an equal "brightness" difference from each other (I don't remember how exactly I did it). I do not wish to break the symmetry.

shaft wrote: > https://en.wikipedia.org/wiki/Von_Luschan's_chromatic_scale#/media/File:Imprecise-Biasutti-map.jpg > > https://upload.wikimedia.org/wikipedia/commons/3/3c/Felix_von_Luschan_Skin_Color_chart.svg > > Here's a reference of skin color distribution. As you can see most countries' native skin colors in Europe and Asia are below 14 on the scale. Just pick some (10 like you already have is probably enough, just take every fifth) and use an imagebutton and [fill: Bumping from 10 to 14 skins sounds OK. I wonder if I could get away by just adding a few lighter levels than the current brightest one without changing the hue in order to keep the symmetry. Another option would be to change the hue of ALL skins. Meh. `[fill` won't work, all the skin colors are stored textures and NOT auto-generated (this is by design as this allows maximum freedom for texture pack authors). But drawing new textures is easy. The hard part is picking good colors. Currently, the 10 skin colors have been carefully chosen to have an equal "brightness" difference from each other (I don't remember how exactly I did it). I do not wish to break the symmetry.

Wuzzy commented 2026年05月20日 21:54:00 +02:00

This issue is now mostly completed. Two new hues and three new lightness levels have been added.

There is now a total of 42 skin colors.

The new skin colors need to be applied to villagers as well.

This issue is now mostly completed. Two new hues and three new lightness levels have been added. There is now a total of 42 skin colors. The new skin colors need to be applied to villagers as well.

Wuzzy commented 2026年05月30日 13:39:46 +02:00

Done! Newly spawned villagers will now use rp_player_skins to grab a base skin at random. Villagers now support all skin colors, hairs, eyes and beards that players also have.

Closing.

Done! Newly spawned villagers will now use `rp_player_skins` to grab a base skin at random. Villagers now support all skin colors, hairs, eyes and beards that players also have. Closing.