Governa commented 2020年12月24日 02:45:19 +01:00 (Migrated from github.com)

Without any parameters, both classes used to generate wildly different results.

This pull request tries to make both results look the same. Although the image size is still not the same when looking at the browser, the proportions are much closer. This can be seen by looking where in the barcode the text starts/ends.

Without any parameters, both classes used to generate wildly different results. This pull request tries to make both results look the same. Although the image size is still not the same when looking at the browser, the proportions are much closer. This can be seen by looking where in the barcode the text starts/ends.

codecov[bot] commented 2020年12月24日 02:46:00 +01:00 (Migrated from github.com)

Codecov Report

Merging #101 (f103c83) into master (7a15b8a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 81.82% 81.85% +0.02% 
==========================================
 Files 15 15 
 Lines 787 788 +1 
==========================================
+ Hits 644 645 +1 
 Misses 143 143 

Impacted Files	Coverage Δ
barcode/writer.py	94.27% <100.00%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a15b8a...f103c83. Read the comment docs.

# [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=h1) Report > Merging [#101](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=desc) (f103c83) into [master](https://codecov.io/gh/WhyNotHugo/python-barcode/commit/7a15b8ae1327a194634ab385e88f433f738dc8e0?el=desc) (7a15b8a) will **increase** coverage by `0.02%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #101 +/- ## ========================================== + Coverage 81.82% 81.85% +0.02% ========================================== Files 15 15 Lines 787 788 +1 ========================================== + Hits 644 645 +1 Misses 143 143 ``` | [Impacted Files](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [barcode/writer.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101/diff?src=pr&el=tree#diff-YmFyY29kZS93cml0ZXIucHk=) | `94.27% <100.00%> (+0.02%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=footer). Last update [7a15b8a...f103c83](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

WhyNotHugo commented 2020年12月24日 13:06:17 +01:00 (Migrated from github.com)

Idea makes sense and code looks perfect. Thanks!

Idea makes sense and code looks perfect. Thanks!