WIP: Add QR Code to Send Push Messages from an external device #2

maximiliangalanis commented 2025年01月17日 14:42:11 +01:00

This adds a button that shows a QR code containing the subscription information necessary to use the subscription: the URL endpoint and the vapid authorization header.

This adds a button that shows a QR code containing the subscription information necessary to use the subscription: the URL endpoint and the vapid authorization header.

maximiliangalanis commented 2025年01月17日 14:43:05 +01:00

It works already. I would appreciate feedback on the implementation :)

It works already. I would appreciate feedback on the implementation :)

s1m commented 2025年01月22日 10:04:14 +01:00

Thanks !

A few things about the implementation:

• We don't need to store the vapid header in the shared prefs, we just call the getVapidHeader when we need it
• We don't need to introduce a parameter to force a new header (createNew). I think you have done it to avoid getting the one in cache ? The VAPID header is valid for 12h, and cached for 5min, so it is not important if we get the cached one (it will still be valid for almost 12h)

Regarding the content of the QR code, maybe it can be an URL taking the required elements in the fragment part, for instance:
https://example.unifiedpush.org/#endpoint=http://endpoint&p256dh=aa&auth=aa&vapid=aaaa

Thanks ! A few things about the implementation: - We don't need to store the vapid header in the shared prefs, we just call the getVapidHeader when we need it - We don't need to introduce a parameter to force a new header (`createNew`). I think you have done it to avoid getting the one in cache ? The VAPID header is valid for 12h, and cached for 5min, so it is not important if we get the cached one (it will still be valid for almost 12h) Regarding the content of the QR code, maybe it can be an URL taking the required elements in the fragment part, for instance: https://example.unifiedpush.org/#endpoint=http://endpoint&p256dh=aa&auth=aa&vapid=aaaa

s1m commented 2025年02月03日 23:07:59 +01:00

@maximiliangalanis We can use https://unifiedpush.org/test_wp.html for the QR code !

https://unifiedpush.org/test_wp.html#endpoint=ENDPOINT&auth=AUTH&p256dh=PUBKEY and you can add &vapid=authorization header

@maximiliangalanis We can use https://unifiedpush.org/test_wp.html for the QR code ! https://unifiedpush.org/test_wp.html#endpoint=ENDPOINT&auth=AUTH&p256dh=PUBKEY and you can add &vapid=authorization header

s1m commented 2025年02月08日 09:57:10 +01:00

I've added the link to the app: c7e90ea5c5

I've added the link to the app: https://codeberg.org/UnifiedPush/android-example/commit/c7e90ea5c5a3cc64e34548b2be3bea4aa92904cc

This pull request has changes conflicting with the target branch.