6
13
Fork
You've already forked craftering
22

Add tusharhero's pages #13

Merged
shom merged 3 commits from :main into main 2024年04月17日 07:48:24 +02:00
Contributor
Copy link

I have just added the website uri twice for the RSS feed, and as you asked in #12 I will eventually add an RSS feed too.

I have just added the website uri twice for the RSS feed, and as you asked in #12 I will eventually add an RSS feed too.
Author
Contributor
Copy link

Would you me to format all the entries uniformly?

Would you me to format all the entries uniformly?
Collaborator
Copy link

Hey @tusharhero please leave the RSS blank as in just empty quotes for the value "" until you have RSS. Feel free to make and push another commit with that change and also with formatting the json indent in your section so I can directly merge your PR. I'm also happy to do the formatting for you and merge (it'll show your commit but your PR will "look" unmerged but I will retitle it [Merged with edit])

Hey @tusharhero please leave the RSS blank as in just empty quotes for the value "" until you have RSS. Feel free to make and push another commit with that change and also with formatting the json indent in your section so I can directly merge your PR. I'm also happy to do the formatting for you and merge (it'll show your commit but your PR will "look" unmerged but I will retitle it [Merged with edit])
Collaborator
Copy link

@tusharhero just formatting your section would be great. Thanks!

@tusharhero just formatting your section would be great. Thanks!
Author
Contributor
Copy link

Weird, it looks nice in emacs, but looks weird in codeberg. Is it a tabs vs spaces thing?

Weird, it looks nice in emacs, but looks weird in codeberg. Is it a tabs vs spaces thing?
Collaborator
Copy link

Yes it's tabs vs spaces. For now just replicate what you have in the first two parameters. I'll normalize it in a single commit for the whole file, so git blame will be easy to follow (if ever needed).

Yes it's tabs vs spaces. For now just replicate what you have in the first two parameters. I'll normalize it in a single commit for the whole file, so git blame will be easy to follow (if ever needed).
Author
Contributor
Copy link

Is it better now?

Is it better now?
shom referenced this pull request from a commit 2024年04月17日 07:48:26 +02:00
Collaborator
Copy link

Hey @tusharhero I've merged it, welcome to the ring!

Your site needs to have the slug url corrected to have the @ sign in the link. I have the new ring generated, I'll deploy it when your site links are corrected. Going to bed now, I'll check in the morning. Welcome Crafter!

Hey @tusharhero I've merged it, welcome to the ring! Your site needs to have the slug url corrected to have the @ sign in the link. I have the new ring generated, I'll deploy it when your site links are corrected. Going to bed now, I'll check in the morning. Welcome Crafter!
Author
Contributor
Copy link

Hey @shom , I have added the proper slug now.

Hey @shom , I have added the proper slug now.
Collaborator
Copy link

Hi @tusharhero! You're live on the ring, welcome on board. Swing by the it channel and say hi to the other ring members! Thanks for joining.

Hi @tusharhero! You're live on the ring, welcome on board. Swing by the it channel and say hi to the other ring members! Thanks for joining.
Author
Contributor
Copy link

Thanks! Which channel are you talking about?

Thanks! Which channel are you talking about?
Collaborator
Copy link

The one mentioned in the ring instructions #SystemCrafters on Libera, more info here: https://systemcrafters.net/community/#chat-with-us

The one mentioned in the ring instructions #SystemCrafters on Libera, more info here: https://systemcrafters.net/community/#chat-with-us
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SystemCrafters/craftering!13
Reference in a new issue
SystemCrafters/craftering
No description provided.
Delete branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?