Sughosha - Codeberg.org

Why here too?

Why here too?

Why realignment?

@kestrelwx wrote in guix/guix#9855 (comment):

@hugobuddel wrote in guix/guix#9812 (comment):

This does not update to a newer version, but only an input is removed. Rewrite the commit message?

@niqc wrote in guix/guix#9812 (comment):

This Plasmoid is interesting, thank you for adding this. I am leaving some suggestions.

Following the other suggested changes, this needs to be added after the unpack phase.

First see guix/guix#9812/files (comment). Once you move the mentioned package to the newly introduced kde-xyz module, you don't need to use these two...

This line exeeds 80 charectars (96 charectars in total). Along with the above suggestion of realining the whole list of arguments, you need to figure out how you can reduce the line. I think...

Justify why you disabled the tests.

After #:tests? key and its value, considering the build-system switch to cmake-build-system, add #:configure-flags with #~(list "-DINSTALL_PLASMOID=ON"), as given in the example in...

Following the change in the build system to cmake-build-system suggested in guix/guix#9812/files (comment), this phase is of no need and needs to be removed.

It is better to set build-system to cmake-build-system, but then you need to manually build and install the Python backend, which needs additional phases.

Move inputs after native-inputs.

Move the license field at the end.

qtbase needs to be in inputs or propagated-inputs.

Once the build system is switched to cmake-build-system, according to the suggestion in guix/guix#9812/files (comment), cmake would not be needed in...

Add kiconthemes, kirigami, ksvg, libplasma, qt5compat, and qtdeclarative to propagated-inputs. For more information on why, see !8974. This command would show which modules are...