10
3
Fork
You've already forked sciop-cli
4

human readable strings for piece sizes #31

Open
sneakers-the-rat wants to merge 3 commits from human-size into main
pull from: human-size
merge into: Safeguarding:main
Safeguarding:main
Safeguarding:api-call
Safeguarding:autopiecesize
Safeguarding:v2-only
Safeguarding:default-trackers
Safeguarding:create-torrent
Safeguarding:ci-init

extremely annoying to have to look up that "16 mebibyte piece sizes" are the integer 16777216 every time, so add a parser for human readable (kibibyte and mebibyte) piece sizes that can be specified from the cli and elsewhere like 16M (or any letter-only string that starts with k or m, case insensitive).

extremely annoying to have to look up that "16 mebibyte piece sizes" are the integer `16777216` every time, so add a parser for human readable (kibibyte and mebibyte) piece sizes that can be specified from the cli and elsewhere like `16M` (or any letter-only string that starts with k or m, case insensitive).
human readable strings for piece sizes
Some checks failed
lint / black (pull_request) Successful in 41s
lint / ruff (pull_request) Successful in 39s
lint / mypy (pull_request) Failing after 1m5s
tests / tests (pull_request) Successful in 2m33s
60ba04fe5c
finish docstring
Some checks failed
lint / black (pull_request) Successful in 39s
lint / ruff (pull_request) Successful in 39s
lint / mypy (pull_request) Failing after 1m4s
tests / tests (pull_request) Successful in 2m11s
6c5dfa94b7
mypy
All checks were successful
lint / black (pull_request) Successful in 40s
lint / ruff (pull_request) Successful in 39s
lint / mypy (pull_request) Successful in 1m6s
tests / tests (pull_request) Successful in 2m13s
5cfb1379f3
All checks were successful
lint / black (pull_request) Successful in 40s
Required
Details
lint / ruff (pull_request) Successful in 39s
Required
Details
lint / mypy (pull_request) Successful in 1m6s
Required
Details
tests / tests (pull_request) Successful in 2m13s
Required
Details
This pull request has changes conflicting with the target branch.
  • CHANGELOG.md
  • pdm.lock
  • src/sciop_cli/types.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin human-size:human-size
git switch human-size
Sign in to join this conversation.
No reviewers
Labels
Clear labels
api
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Tech Debt
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Safeguarding/sciop-cli!31
Reference in a new issue
Safeguarding/sciop-cli
No description provided.
Delete branch "human-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?