7
44
Fork
You've already forked nice-plug
22

WIP: improve host->plugin resizing #51

Draft
BillyDM wants to merge 6 commits from resizing into main
pull from: resizing
merge into: RustAudio:main
RustAudio:main
RustAudio:dev
RustAudio:standalone_fixes
RustAudio:FoobarIT/main
RustAudio:fixes
RustAudio:egui_3rd_party
RustAudio:vizia_baseview_update
RustAudio:egui_32
RustAudio:softbuffer
RustAudio:byo_gui_examples
RustAudio:raw_graphics_examples

While trying to implement the new host->plugin resizing in nice-plug-egui, I noticed that the API/logic for host resizing could be improved.

  • Added min_logical_size and max_logical_size to ResizeHint.
  • Renamed Editor::set_size to Editor::set_physical_size. Knowing the exact physical size of the window is important for some GUI libraries.
  • Added Editor::adjust_physical_size which by default uses ResizeHint::adjust_physical_size. Users can override this if they want custom behavior, like snapping to preset scaling increments.
  • Implemented logic in the CLAP backend's ext_gui_adjust_size function and the VST3 backend's checkSizeConstraint function.

However, it's not actually working correctly, so I need to do some more debugging.

While trying to implement the new host->plugin resizing in `nice-plug-egui`, I noticed that the API/logic for host resizing could be improved. * Added `min_logical_size` and `max_logical_size` to `ResizeHint`. * Renamed `Editor::set_size` to `Editor::set_physical_size`. Knowing the exact physical size of the window is important for some GUI libraries. * Added `Editor::adjust_physical_size` which by default uses `ResizeHint::adjust_physical_size`. Users can override this if they want custom behavior, like snapping to preset scaling increments. * Implemented logic in the CLAP backend's `ext_gui_adjust_size` function and the VST3 backend's `checkSizeConstraint` function. However, it's not actually working correctly, so I need to do some more debugging.
Author
Owner
Copy link

Actually, I'm realizing I may need to completely rework how nice-plug handles scaling and resizing. I'll play around with some ideas.

Actually, I'm realizing I may need to completely rework how nice-plug handles scaling and resizing. I'll play around with some ideas.
This pull request has changes conflicting with the target branch.
  • crates/nice-plug-egui/src/editor.rs
  • crates/nice-plug-egui/src/lib.rs
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin resizing:resizing
git switch resizing

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff resizing
git switch resizing
git rebase main
git switch main
git merge --ff-only resizing
git switch resizing
git rebase main
git switch main
git merge --no-ff resizing
git switch main
git merge --squash resizing
git switch main
git merge --ff-only resizing
git switch main
git merge resizing
git push origin main
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
RustAudio/nice-plug!51
Reference in a new issue
RustAudio/nice-plug
No description provided.
Delete branch "resizing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?