7
44
Fork
You've already forked nice-plug
22

allow user to request different ui scale after window is open #17

Merged
BillyDM merged 1 commit from maor1993/nih-plug:main into main 2026年05月27日 00:53:21 +02:00
Contributor
Copy link

egui state currently has this function as private.
however, it is useful for creating user configurable scale option -
image

egui state currently has this function as private. however, it is useful for creating user configurable scale option - ![image](/attachments/fb11057f-858d-4506-ba68-a011b3db169c)

The intended method is to use Queue::resize() BillyDM/nih-plug@10b716a394/baseview-adapters/egui-baseview/src/window.rs (L50)

Does that method work as intended for you?

The intended method is to use `Queue::resize()` https://codeberg.org/BillyDM/nih-plug/src/commit/10b716a394b178a9aa7263ea2775ec2e319a996a/baseview-adapters/egui-baseview/src/window.rs#L50 Does that method work as intended for you?
Author
Contributor
Copy link

Just tried using this function, the resize changes the UI size but not the window size -
image
using the PR I made updates both.

Just tried using this function, the resize changes the UI size but not the window size - ![image](/attachments/fccdf214-dda7-4bdf-b685-0e753db41e1f) using the PR I made updates both.

Sorry for taking so long to get around to this. Is the intended method fixed in BillyDM/nice-plug@83a0d7b02d?

Sorry for taking so long to get around to this. Is the intended method fixed in https://codeberg.org/BillyDM/nice-plug/commit/83a0d7b02db23f1940e110f459d63f72a2fe0de0?
Author
Contributor
Copy link

Hey @BillyDM , on the commit you marked its the same, UI resizes but window does not scale with it.

Hey @BillyDM , on the commit you marked its the same, UI resizes but window does not scale with it.

Huh, that is strange. I'll do more debugging to figure out why it isn't working.

Huh, that is strange. I'll do more debugging to figure out why it isn't working.

Oh, you're right, my bad. I forgot that the way baseview handles resizing and the way plugins handle resizing are two completely different processes. So making that method public is the correct way.

Oh, you're right, my bad. I forgot that the way `baseview` handles resizing and the way plugins handle resizing are two completely different processes. So making that method public is the correct way.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
RustAudio/nice-plug!17
Reference in a new issue
RustAudio/nice-plug
No description provided.
Delete branch "maor1993/nih-plug:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?