2
5
Fork
You've already forked layfetch
2

implemented feature: shell script relative paths #8

Merged
PerfectlyInternal merged 2 commits from allymander/7-relative-path-to-script:main into main 2026年03月06日 21:15:38 +01:00
Contributor
Copy link

Implemented feature request from #7. Implementation could use some cleanup for codebase aesthetics, but works properly on my machine. The logic permits storing executables in layout_dir and arbitrarily deep subdirectories thereof. It's my first time working with Rust, so I'm not really familiar with language best practices, but I tried to maintain the style of the codebase to the best of my abilities.

P.S. I forgot to turn my auto-formatter off while writing the patch! >.< Sorry for the massive diff, I can reformat before merge if desired.

Implemented feature request from #7. Implementation could use some cleanup for codebase aesthetics, but works properly on my machine. The logic permits storing executables in `layout_dir` and arbitrarily deep subdirectories thereof. It's my first time working with Rust, so I'm not really familiar with language best practices, but I tried to maintain the style of the codebase to the best of my abilities. P.S. I forgot to turn my auto-formatter off while writing the patch! >.< Sorry for the massive diff, I can reformat before merge if desired.

Looks like the logic works. If you could undo the formatting changes that'd be great. Also, in the future, you can create a separate branch on your fork of the project instead of creating a whole fork for one PR. Thanks for the contribution!

Looks like the logic works. If you could undo the formatting changes that'd be great. Also, in the future, you can create a separate branch on your fork of the project instead of creating a whole fork for one PR. Thanks for the contribution!
Author
Contributor
Copy link

Reverted formatting, and tip noted!

Reverted formatting, and tip noted!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
PerfectlyInternal/layfetch!8
Reference in a new issue
PerfectlyInternal/layfetch
No description provided.
Delete branch "allymander/7-relative-path-to-script:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?