tests: add missing header <algorithm> #3

varunbpatil commented 2024年12月19日 06:32:04 +01:00

Fixes a compile error introduced by commit db5884ca14.

Fixes a compile error introduced by commit https://codeberg.org/OpenVPN/gdbuspp/commit/db5884ca145de9d5d6b8426410cefb6171efd270.

dazo commented 2024年12月19日 10:26:22 +01:00

Thanks a lot for this fix! I see we're lacking a clear contribution guide ... so I'll just have a few minor details about the commit message:

• The prefix in your commit should be tests: since it's the testing code receiving the change. (see the git log --oneline to get an idea of the various scopes commonly used)
• We want the Signed-off-by lines (git commit -s) by default. The background for it is the "Developers Certificate of Origin". Basically that you acknowledge and agree that you own the commit and change and it is contributed to this project and will be distributed/shared further according to the license of this project.

If you would like to be credited with this change, please update the pull-request and I can bring it it. I know it might feel a bit much for a one-line change, but it's a young project and we should set the standard and enforce it as early as possible to make it clearer for the ones coming after us.

I'll clarify these details in coming days in the project documentation in the coming days too.

Thanks a lot for this fix! I see we're lacking a clear contribution guide ... so I'll just have a few minor details about the commit message: * The prefix in your commit should be `tests:` since it's the testing code receiving the change. (see the `git log --oneline` to get an idea of the various scopes commonly used) * We want the `Signed-off-by` lines (`git commit -s`) by default. The background for it is the ["Developers Certificate of Origin"](https://developercertificate.org/). Basically that you acknowledge and agree that you own the commit and change and it is contributed to this project and will be distributed/shared further according to the license of this project. If you would like to be credited with this change, please update the pull-request and I can bring it it. I know it might feel a bit much for a one-line change, but it's a young project and we should set the standard and enforce it as early as possible to make it clearer for the ones coming after us. I'll clarify these details in coming days in the project documentation in the coming days too.

dazo commented 2024年12月19日 10:45:29 +01:00

Thanks a lot for the changes! I spotted too late (after your latest changes) that the commit message could have too more details too. I just fixed that on-the-fly; the most important changes was done by you - and it was just to bring in details from this pull-req.

Thanks a lot for the changes! I spotted too late (after your latest changes) that the commit message could have too more details too. I just fixed that on-the-fly; the most important changes was done by you - and it was just to bring in details from this pull-req.

dazo commented 2024年12月19日 10:46:08 +01:00

This has been merged with a slightly modified commit message.

Commit b19cd052cb

This has been merged with a slightly modified commit message. Commit b19cd052cb88e03ba393bc9f0cb669baeb9d76de