BiliBili: Fix only first page of comment replies loaded #16

chr_56 commented 2025年09月24日 10:38:01 +02:00

In commit 03d09239, the COMMENT_REPLIES_URL was changed: ps=20 -> ps=10

@@ -90,7 +69,7 @@ public class BilibiliService extends StreamingService {
- public static String COMMENT_REPLIES_URL = "https://api.bilibili.com/x/v2/reply/reply?type=1&ps=10&pn=1&web_location=333.788&oid=";
+ public static String COMMENT_REPLIES_URL = "https://api.bilibili.com/x/v2/reply/reply?type=1&pn=1&ps=20&oid=";

But there are other two relative places keeping unmodified:

• First one is checking next page from BilibiliCommentExtractor:

 } else { //replies
 // results are replies, but at most 10 now
 if (19 > results.size() && pageUrl.contains("pn=1")) {
 return new InfoItemsPage<>(collector, null);
 }
 return new InfoItemsPage<>(collector, new Page(utils.getNextPageFromCurrentUrl(pageUrl, "pn", 1), getDefaultCookies()));
 }

• The other one is in getUrl() from BilibiliCommentsLinkHandlerFactory:

 if(id.contains("&root")){
 // I don't know why but pn must be placed in the end or nothing will be fetched
 return "https://api.bilibili.com/x/v2/reply/reply?type=1&ps=20&oid=" + id + "&pn=1";
 // `ps` still remains 20 here
 }

In commit 03d09239, the `COMMENT_REPLIES_URL` was changed: `ps=20` -> `ps=10` ```diff @@ -90,7 +69,7 @@ public class BilibiliService extends StreamingService { - public static String COMMENT_REPLIES_URL = "https://api.bilibili.com/x/v2/reply/reply?type=1&ps=10&pn=1&web_location=333.788&oid="; + public static String COMMENT_REPLIES_URL = "https://api.bilibili.com/x/v2/reply/reply?type=1&pn=1&ps=20&oid="; ``` But there are other two relative places keeping unmodified: - First one is checking next page from `BilibiliCommentExtractor`: ```kotlin } else { //replies // results are replies, but at most 10 now if (19 > results.size() && pageUrl.contains("pn=1")) { return new InfoItemsPage<>(collector, null); } return new InfoItemsPage<>(collector, new Page(utils.getNextPageFromCurrentUrl(pageUrl, "pn", 1), getDefaultCookies())); } ``` - The other one is in `getUrl()` from `BilibiliCommentsLinkHandlerFactory`: ```kotlin if(id.contains("&root")){ // I don't know why but pn must be placed in the end or nothing will be fetched return "https://api.bilibili.com/x/v2/reply/reply?type=1&ps=20&oid=" + id + "&pn=1"; // `ps` still remains 20 here } ```