4
9
Fork
You've already forked PipePipeClient
7

[Enhancement][UI] Enhanced Full-functional Image Viewer for Images Attached in Comments #31

Merged
NullPointerException merged 7 commits from chr_56/PipePipeClient:image-viewer into dev 2025年06月13日 11:30:55 +02:00
Contributor
Copy link

Replace PictureDialog with ImageViewerActivity, (削除) borrowed from my other projects (削除ここまで).

Thanks to com.github.chrisbanes:PhotoView, now this image detail dialog (activity) can:

  • Full screen
  • Zoom
  • Swipe to switch
  • Download / Copy URI / Open in browser
Replace `PictureDialog` with `ImageViewerActivity`, ~borrowed from my other projects~. Thanks to [com.github.chrisbanes:PhotoView](https://github.com/Baseflow/PhotoView), now this image detail dialog (activity) can: - Full screen - Zoom - Swipe to switch - Download / Copy URI / Open in browser
@ -0,0 +111,4 @@
window.addFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_NAVIGATION)
WindowCompat.getInsetsController(window, window.decorView).apply {
isAppearanceLightStatusBars = false

e: ImageViewerActivity.kt: (114, 13): Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type WindowInsetsControllerCompat?

can't compile here, can you check again?

e: ImageViewerActivity.kt: (114, 13): Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type WindowInsetsControllerCompat? can't compile here, can you check again?
Author
Contributor
Copy link

Sorry.

WindowCompat is from androidx.core. I've upgrade many dependencies, as well as SDK. Old SDK, Kotlin, and this dependency would cause false positive check.

Sorry. `WindowCompat` is from `androidx.core`. I've upgrade many dependencies, as well as SDK. Old SDK, Kotlin, and this dependency would cause false positive check.
chr_56 marked this conversation as resolved
@ -0,0 +112,4 @@
WindowCompat.getInsetsController(window, window.decorView).apply {
isAppearanceLightStatusBars = false
isAppearanceLightNavigationBars = false

same with this line

same with this line
chr_56 marked this conversation as resolved
Author
Contributor
Copy link

It's fine now: build with original toolchain on GitHubAction

It's fine now: build with original toolchain on [GitHubAction](https://github.com/chr56/PipePipe/actions/runs/15629571348)

PhotoView is great, but for the activity I would suggest this layout:

Screenshot

What's your opinion?

PhotoView is great, but for the activity I would suggest this layout: ![Screenshot](/attachments/683bf864-f361-4383-ba36-74cf5f620182) What's your opinion?
Author
Contributor
Copy link

What's your opinion?

I have no preference for both; they look both fine to me.

> What's your opinion? I have no preference for both; they look both fine to me.

Then I think mine is better XD. It would be nice if you can modify it.

Then I think mine is better XD. It would be nice if you can modify it.
Author
Contributor
Copy link

Done in 8d6c70c374.

That's it. I do not want to adjust it anymore: GithubAction

Done in 8d6c70c37404b67637a42f02dbcc1aceaef73d24. That's it. I do not want to adjust it anymore: [GithubAction](https://github.com/chr56/PipePipe/actions/runs/15630851717)

Thanks.

Thanks.
chr_56 deleted branch image-viewer 2025年06月13日 11:45:00 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
NullPointerException/PipePipeClient!31
Reference in a new issue
NullPointerException/PipePipeClient
No description provided.
Delete branch "chr_56/PipePipeClient:image-viewer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?