[New Feature][UI] some easier ways to access PlayerQueue when backgroud streaming #17

chr_56 commented 2024年04月09日 16:53:35 +02:00

As we all know, to open PlayerQueueActivity if you play something background, you have to drop down notification bar, and click playback notification.

That is not a quite pleasant experience if you a large queue and want to manage it frequently, via this tedious way to access PlayerQueueActivity.

Now this PR provides 2 new ways to access PlayerQueue much more easily:

1. Long press PlayPause button deck player bar. (Only when backgroud streaming)
2. Long press Background button in video detail fragment (this means enqueue it as well), PlayerQueueActivity would be showed, only after starting background streaming (i.e the second stream). This behavior may be controversial, there may be some room to discuss whether to leave a user opt-in preference to control this behavior.

As we all know, to open PlayerQueueActivity if you play something background, you have to drop down notification bar, and click playback notification. That is not a quite pleasant experience if you a large queue and want to manage it frequently, via this tedious way to access PlayerQueueActivity. Now this PR provides 2 new ways to access PlayerQueue much more easily: 1. Long press `PlayPause` button deck player bar. (Only when backgroud streaming) 2. Long press `Background` button in video detail fragment (this means enqueue it as well), PlayerQueueActivity would be showed, only after starting background streaming (i.e the second stream). _This behavior may be controversial, there may be some room to discuss whether to leave a user opt-in preference to control this behavior._

NullPointerException commented 2024年05月12日 10:52:14 +02:00

Thank you. The long press behavior on the play/pause button is clever, but adding a long press behavior to the background would be a bit odd. For the second commit, I think a better way would be, as you suggested, to add a preference to control the long press behavior on the background (defaulting to adding to the queue).

Thank you. The long press behavior on the play/pause button is clever, but adding a long press behavior to the background would be a bit odd. For the second commit, I think a better way would be, as you suggested, to add a preference to control the long press behavior on the background (defaulting to adding to the queue).

NullPointerException commented 2024年05月12日 10:52:37 +02:00

I have cherry-picked the first commit.

I have cherry-picked the first commit.