4
9
Fork
You've already forked PipePipeClient
7

[New Feature][UI] some easier ways to access PlayerQueue when backgroud streaming #16

Closed
chr_56 wants to merge 2 commits from chr_56/PipePipeClient:quick_access_to_player_queue into dev
pull from: chr_56/PipePipeClient:quick_access_to_player_queue
merge into: NullPointerException:dev
NullPointerException:dev
NullPointerException:legacy
NullPointerException:main
Contributor
Copy link

As we all know, to open PlayerQueueActivity if you play something background, you have to drop down notification bar, and click playback notification.

That is not a quite pleasant experience if you a large queue and want to manage it frequently, via this tedious way to access PlayerQueueActivity.

Now this PR provides 2 new ways to access PlayerQueue much more easily:

  1. Long press PlayPause button deck player bar. (Only when backgroud streaming)
  2. Long press Background button in video detail fragment (this means enqueue it as well), PlayerQueueActivity would be showed, only after starting background streaming (i.e the second stream). This behavior may be controversial, there may be some room to discuss whether to leave a user opt-in preference to control this behavior.
As we all know, to open PlayerQueueActivity if you play something background, you have to drop down notification bar, and click playback notification. That is not a quite pleasant experience if you a large queue and want to manage it frequently, via this tedious way to access PlayerQueueActivity. Now this PR provides 2 new ways to access PlayerQueue much more easily: 1. Long press `PlayPause` button deck player bar. (Only when backgroud streaming) 2. Long press `Background` button in video detail fragment (this means enqueue it as well), PlayerQueueActivity would be showed, only after starting background streaming (i.e the second stream). _This behavior may be controversial, there may be some room to discuss whether to leave a user opt-in preference to control this behavior._
Author
Contributor
Copy link

I don't know why and how two exactly same PRs have been created.
This is a quite strange bug of CodeBerg.

Close one.

I don't know **why and how** two exactly same PRs have been created. This is a quite strange bug of CodeBerg. Close one.
chr_56 closed this pull request 2024年04月09日 16:58:32 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
NullPointerException/PipePipeClient!16
Reference in a new issue
NullPointerException/PipePipeClient
No description provided.
Delete branch "chr_56/PipePipeClient:quick_access_to_player_queue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?