[New Features] [BiliBili] extract and display stream detailed statistic & comment pictures dialog & merge upstream (Client Side) #11

chr_56 commented 2023年12月27日 14:36:30 +01:00

This contains:

1. Merge upstream changes on Description fragments with relative utilities update:
   Upstream pulled up a BaseDescriptionFragment and use it in Channel's about tab, and introduced
   a model class Image in extractor to improve avatars and thumbnails extracting (all image url
   extracting method are replaced with corresponding Image collection extracting method, but I
   kept the legacy codes and redirected to the legacy since we can not afford large changes on
   "unmaintained" services). This as well results in supporting various size images extracting
   instead of one url in Metadata section (by refactoring of TextLinkifier with new text-span
   utils).
2. Extract and display BiliBili stream detailed statistic:
   Some "very important" BiliBili stream stats (for "most BiliBili user"), like coins count and
   danmaku count and view count, are showed in Metadata section (We can later display them along
   with "YouTube like count" position if available) by extending StreamInfo with relative changes
   on DescriptionFragment.
3. Add PictureDialog to view pictures in comments:
   I extended CommentsInfoItem to store attached pictures in formats of Image, and
   created PictureDialog to view pictures in CommentsInfoItemHolder. Currently, it's in state
   of "just working" requiring ongoing refinement and polish.

This require correspond Extractor PR.

This contains: 1. Merge upstream changes on Description fragments with relative utilities update: Upstream pulled up a `BaseDescriptionFragment` and use it in Channel's about tab, and introduced a model class `Image` in extractor to improve avatars and thumbnails extracting (all image url extracting method are replaced with corresponding `Image` collection extracting method, but I kept the legacy codes and redirected to the legacy since we can not afford large changes on "unmaintained" services). This as well results in supporting various size images extracting instead of one url in Metadata section (by refactoring of `TextLinkifier` with new text-span utils). 2. Extract and display BiliBili stream detailed statistic: Some "very important" BiliBili stream stats (for "most BiliBili user"), like coins count and danmaku count and view count, are showed in Metadata section (We can later display them along with "YouTube like count" position if available) by extending `StreamInfo` with relative changes on DescriptionFragment. 3. Add PictureDialog to view pictures in comments: I extended `CommentsInfoItem` to store attached pictures in formats of `Image`, and created `PictureDialog` to view pictures in `CommentsInfoItemHolder`. Currently, it's in state of "just working" requiring ongoing refinement and polish. This require correspond [Extractor PR](https://codeberg.org/NullPointerException/PipePipeExtractor/pulls/8).

NullPointerException commented 2023年12月28日 01:34:49 +01:00

Please make separate PR for the 2 features.

Please make separate PR for the 2 features.

NullPointerException commented 2024年01月05日 22:47:52 +01:00

Merged locally with some adjustments. Thanks.
btw, do you still have other plans? We can discuss them before starting to avoid merge conflicts.

Merged locally with some adjustments. Thanks. btw, do you still have other plans? We can discuss them before starting to avoid merge conflicts.

chr_56 commented 2024年01月06日 03:33:05 +01:00

Thank you.

And, I may try to open an issue first before starting implement a new feature next times.

PS: I have reported to Codeberg community the problem that Extractor repo can not receive any PR. It is said to be caused by stale lock files and would notify as soon it recovered.

Thank you. And, I may try to _open an issue first_ before starting implement a new feature next times. PS: I have reported to Codeberg community the problem that Extractor repo can not receive any PR. It is said to be caused by stale lock files and would notify as soon it recovered.