[New Feature](BiliBili) display Staff List for cooperation videos (Client Side) #10

chr_56 commented 2023年12月25日 05:54:55 +01:00

Require NullPointerException/PipePipeExtractor#6

Require https://codeberg.org/NullPointerException/PipePipeExtractor/pulls/6

NullPointerException commented 2023年12月26日 00:34:37 +01:00

Looks good to me. But for UI I would prefer showing staffs as a scrollable horizontal list.

Looks good to me. But for UI I would prefer showing staffs as a scrollable horizontal list.

chr_56 commented 2023年12月26日 05:19:34 +01:00

Actually, I prefer not.

Reason:

1. This is PipePipe, not official BiliBili Android Client -- We do not need to be a parody.
2. Some user's name is too long, so that it can not be shown completely in horizontal list like the official's (so they even use a detail bottom sheet in vertical list to show).
3. Complexity. Where should we put "Title" (Contribution) in ? As top right corner badge like official's? And with a detail vertical bottom sheet for long username? No, we can not offer such complexities.

My plan, as it has been implemented already:

1. collapsible list (b3238dabb1a0179b105dd462f33e48a9200e7ce3), if list is too long;
2. 2 rows list (a280385945409ea3a0cedc59b4f90d14047db041), for too much blank on right side.

Actually, I prefer not. Reason: 1. This is PipePipe, not official BiliBili Android Client -- We do not need to be a parody. 2. Some user's name is too long, so that it can not be shown completely in horizontal list like the official's (so they even use a detail bottom sheet in vertical list to show). 3. Complexity. Where should we put "Title" (Contribution) in ? As top right corner badge like official's? And with a detail vertical bottom sheet for long username? No, we can not offer such complexities. My plan, as it has been implemented already: 1. collapsible list (b3238dabb1a0179b105dd462f33e48a9200e7ce3), if list is too long; 2. 2 rows list (a280385945409ea3a0cedc59b4f90d14047db041), for too much blank on right side.

chr_56 commented 2023年12月26日 07:20:15 +01:00

Now rebased.

Now rebased.