Restructured argument parsing, robust IoError, typos corrected, etc. #60

EnronEvolved commented 2025年08月16日 14:15:27 +02:00 (Migrated from github.com)

This pull requests lumps together a number of changes:

• The argument parsing logic has been restructured to use new language features, as detailed in the commit log. I think the logic survived the restructuring. We shall have to see how tests shake out.
• Archive.IoError has been rewritten as a union of various std.fs.File error sets, so it doesn't break whenever Andrew Kelley and friends twiddle them.
• err_result has been renamed to fallible in Archive.handleFileIoError, to express the idea of the function more clearly.
• Assorted minor spelling mistakes in code comments have been corrected.

These changes build, and pass zig build test locally.

This pull requests lumps together a number of changes: * The argument parsing logic has been restructured to use new language features, as detailed in the commit log. I _think_ the logic survived the restructuring. We shall have to see how tests shake out. * `Archive.IoError` has been rewritten as a union of various `std.fs.File` error sets, so it doesn't break whenever Andrew Kelley and friends twiddle them. * `err_result` has been renamed to `fallible` in `Archive.handleFileIoError`, to express the idea of the function more clearly. * Assorted minor spelling mistakes in code comments have been corrected. These changes build, and pass `zig build test` locally.

moosichu commented 2025年08月16日 22:02:18 +02:00 (Migrated from github.com)

Looks fab thank you! Especially catching my typos 😅

Looks fab thank you! Especially catching my typos 😅