Matching llvm-ar output for GNU format #36

iddev5 commented 2021年11月15日 13:35:11 +01:00 (Migrated from github.com)

This PR makes some changes which now allows zar to generate archives which are compatible with llvm-ar generated archives.
This is only true for GNU format right now as BSD format needs additional offset tricks (BSD is align 8 vs GNU is align 2 which is performed for both right now)

Solutions may not be perfect (especially regarding file mode). Need additional real life testing for that.

Partially addresses #35

This PR unblocks writing tests (only for GNU format), which was previously not possible at all.

Issues with BSD would be addressed in a different PR as my goal is to do a thorough split up of finalize() function into multiple parts so as to do cleanup the mess of this function.

This PR makes some changes which now allows zar to generate archives which are compatible with llvm-ar generated archives. This is only true for GNU format right now as BSD format needs additional offset tricks (BSD is align 8 vs GNU is align 2 which is performed for both right now) Solutions may not be perfect (especially regarding file mode). Need additional real life testing for that. Partially addresses #35 This PR unblocks writing tests (only for GNU format), which was previously not possible at all. Issues with BSD would be addressed in a different PR as my goal is to do a thorough split up of finalize() function into multiple parts so as to do cleanup the mess of this function.

moosichu commented 2021年11月15日 23:21:29 +01:00 (Migrated from github.com)

Oh wow, this is awesome! Wasn't expecting this to be done so quickly. I've not had much time to do anything recently, but hopefully I will do soon. Thank you for this!

Oh wow, this is awesome! Wasn't expecting this to be done so quickly. I've not had much time to do anything recently, but hopefully I will do soon. Thank you for this!