1
0
Fork
You've already forked zar
0

code and style improvments #27

Closed
alichraghi wants to merge 3 commits from master into master
pull from: master
merge into: Moosichu:master
Moosichu:main
Moosichu:actions/cross-compile-redis-windows
Moosichu:feature/mri-parser-integration
Moosichu:actions/zar-redis-ranlib
Moosichu:feature/parse-bsd-symbols
alichraghi commented 2021年10月15日 20:40:43 +02:00 (Migrated from github.com)
Copy link

I also found a bug. if the contents of the archive file have a magic string with a new line, zar does not show an error and creates an infinite loop

!<arch>
I also found a bug. if the contents of the archive file have a magic string with a new line, zar does not show an error and creates an infinite loop ``` !<arch> ```
alichraghi commented 2021年10月15日 20:49:19 +02:00 (Migrated from github.com)
Copy link

i think in this loop
i will try to fix it tomorrow

i think in [this loop](https://github.com/moosichu/zar/blob/master/src/archive/Archive.zig#L587-L590) i will try to fix it tomorrow
moosichu commented 2021年10月16日 02:40:31 +02:00 (Migrated from github.com)
Copy link

Thank you for creating this! Can you please break down the fixes into individual PRs for each one? As a heads up, style change PRs won’t be accepted, no need this early on, so please keep changes limited to features or fixes.

Thank you for creating this! Can you please break down the fixes into individual PRs for each one? As a heads up, style change PRs won’t be accepted, no need this early on, so please keep changes limited to features or fixes.
alichraghi commented 2021年10月16日 06:45:12 +02:00 (Migrated from github.com)
Copy link

sure

sure

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Moosichu/zar!27
Reference in a new issue
Moosichu/zar
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?