MonadicSheep/emacs-reader
14
126
Fork
You've already forked emacs-reader
21

fix: reader.el: Remove key binding for reader-presentation-mode #154

Manually merged
drcxd merged 1 commit from drcxd/emacs-reader:f5-key-binding-fix into master 2025年12月17日 10:14:29 +01:00
Contributor
Copy link
  • reader.el (reader-mode-map): reader-presentation-mode no longer
    binds to F5 since it is reserved for user-defined bindings.

See the official document.

* reader.el (reader-mode-map): reader-presentation-mode no longer binds to F5 since it is reserved for user-defined bindings. See the [official document](https://www.gnu.org/software/emacs/manual/html_node/emacs/Key-Bindings.html).
* reader.el (reader-mode-map): reader-presentation-mode no longer
binds to F5 since it is reserved for user-defined bindings.
drcxd manually merged commit 9606907acd into master 2025年12月17日 10:14:29 +01:00
Author
Contributor
Copy link

Hi, I do not know why the record displays that this has been merged by myself. I do not remember I have clicked any button about merging. Also, I am not supposed to be authorized to execute the merge operation I guess... Actually I was looking forward that you would bind reader-presentation-mode to something else...

Hi, I do not know why the record displays that this has been merged by myself. I do not remember I have clicked any button about merging. Also, I am not supposed to be authorized to execute the merge operation I guess... Actually I was looking forward that you would bind `reader-presentation-mode` to something else...

Hey @drcxd,

Sorry for not clarifying before merging. Codeberg says that, but it
was me who merged your commit.

About binding reader-presentation-mode to something, I was always
opposed to binding reader-presentation-mode. The only reason I agreed
to let it get bound to F5 was because many other document readers have
the same keybinding. But now that the binding has been revealed to
encroach on the user keybindings, I think it is best to leave it to the
user to bind it to some preferable keybinding. I don't think it needs
to be a default.

Hey @drcxd, Sorry for not clarifying before merging. Codeberg says that, but it was me who merged your commit. About binding `reader-presentation-mode` to something, I was always opposed to binding `reader-presentation-mode`. The only reason I agreed to let it get bound to `F5` was because many other document readers have the same keybinding. But now that the binding has been revealed to encroach on the user keybindings, I think it is best to leave it to the user to bind it to some preferable keybinding. I don't think it needs to be a default.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Backend
Issues that are related to or affect the C backend
bug
Something is not working
Build System
Issues related to the buliding process
documentation
Tasks pertaining to documentation, both in-code and externally.
duplicate
This issue or pull request already exists
Emacs
Issues pertaining to integrating with an Emacs package or core.
enhancement
New feature
Frontend
Issues that affect or are related to the Emacs Lisp frontend.
good first issue
Interested in contributing? Get started here.
Heisenbug
We have no idea what's happening, or how to fix.
help wanted
Need some help
invalid
Something is wrong
MuPDF
Issues or features that are essentially about MuPDF.
naming-scheme
Issues related to naming and renaming things.
Needs Testing
An issue that needs further testing.
painful refactor
Requires complete destruction of the present code
question
More information is needed
Research Needed
Issues/features that we are not sure how to implement, and would require a lot of research.
upstream
Related to an upstream repository, already reported there
bug
Something is not working
contribution welcome
Contributions are very welcome, get started here
duplicate
This issue or pull request already exists
enhancement
New feature
good first issue
Interested in contributing? Get started here.
invalid
Something is wrong
question
More information is needed
upstream
Related to an upstream repository, already reported there
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
MonadicSheep/emacs-reader!154
Reference in a new issue
MonadicSheep/emacs-reader
No description provided.
Delete branch "drcxd/emacs-reader:f5-key-binding-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?