Liblast/liblast-framework
7
22
Fork
You've already forked liblast-framework
2

added automatic suggestions to the console #22

Open
yankscally wants to merge 5 commits from feature-console-improvements into main
pull from: feature-console-improvements
merge into: Liblast:main
Liblast:main
Liblast:devel-unfa
Liblast:devel-3d
Liblast:refactor-gamestate
Liblast:snapshot-walking-works
Liblast:backport-gwj80
Liblast:feat/add-third-party-licensing
Liblast:feature_movement_park
Liblast:feature_config_stack
Liblast:devel_refactor-cvars
Liblast:feature_gui

This makes a popup appear with a rather juicy animation and all the text in that search on each character press, instead of pressing tab to switch between.

This makes a popup appear with a rather juicy animation and all the text in that search on each character press, instead of pressing tab to switch between.
Author
Member
Copy link

need some help getting the cvar editor scene out of there not sure how it ended up there. oops.

anyway this is a rather nice change so I made a PR to close the branch off.

improvements that could be made later to commands:

  • being able to read the pixel height of the current font to determine how much to animate the menu size

  • turning the suggestions on and off or using a lite mode with a single suggestion ghosted on the end that you can tab in

  • command history

  • using different syntax and distinguishing namespaces, etc. like liblast:play liblab or football_mod:score goal team red

need some help getting the cvar editor scene out of there not sure how it ended up there. oops. anyway this is a rather nice change so I made a PR to close the branch off. improvements that could be made later to commands: - being able to read the pixel height of the current font to determine how much to animate the menu size - turning the suggestions on and off or using a lite mode with a single suggestion ghosted on the end that you can tab in - command history - using different syntax and distinguishing namespaces, etc. like `liblast:play liblab` or `football_mod:score goal team red`

Heads up, this branch is pretty diverged. It will probably take some work to get it corrected.

Heads up, this branch is pretty diverged. It will probably take some work to get it corrected.
Owner
Copy link

Yeah, it'd probably be best to manually port useful stuff.

Yeah, it'd probably be best to manually port useful stuff.
This pull request has changes conflicting with the target branch.
  • addons/liblast_framework/gui/console/console.tscn
  • addons/liblast_framework/gui/console/console_input.gd
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature-console-improvements:feature-console-improvements
git switch feature-console-improvements
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Upstream
Issue is rooted in Godot Engine or other upstream projects
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Liblast/liblast-framework!22
Reference in a new issue
Liblast/liblast-framework
No description provided.
Delete branch "feature-console-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?