Lexden commented on pull request IPMITool/ipmitool#14 2024年09月17日 18:35:12 +02:00
Allow Sensor Data records to use 6-bit ASCII encoding

nit: mandate* typo

Lexden commented on pull request IPMITool/ipmitool#14 2024年09月17日 18:35:12 +02:00
Allow Sensor Data records to use 6-bit ASCII encoding

32 bytes? Or 42 characters? I do not see how we get to 42 bytes.

Lexden approved IPMITool/ipmitool#14 2024年09月17日 18:35:12 +02:00
Allow Sensor Data records to use 6-bit ASCII encoding

A couple nits on the documentation presented in ipmi_sdr.h, but nothing which affects logic.

Lexden approved IPMITool/ipmitool#37 2024年06月24日 23:35:20 +02:00
Fix ipmi_fru.c typo causing compiles to fail
Lexden commented on pull request IPMITool/ipmitool#1 2023年11月28日 23:49:48 +01:00
Fru: Fix edit field not checking area existence

I made a mistake which duplicated 18 commits. I've force pushed to clean that out.

Lexden pushed to master at Lexden/ipmitool 2023年11月28日 23:48:56 +01:00
b0a6015f35 Refactor and Remove Magic Number
Lexden pushed to master at Lexden/ipmitool 2023年11月28日 22:46:43 +01:00
eb58077c8c Refactor and Remove Magic Number
101da313b7 Refactor variable name
df57eb38fd dcmi: update parameters to read temperature sensors
c581f18746 fru: Refactor for future use
Compare 20 commits »
Lexden pushed to master at Lexden/ipmitool 2023年11月02日 01:28:02 +01:00
a827d8c686 Refactor variable name
Lexden pushed to master at Lexden/ipmitool 2023年11月02日 01:25:50 +01:00
8704087c35 Re-added logging using lprintf
Compare 2 commits »
Lexden commented on pull request IPMITool/ipmitool#1 2023年11月01日 23:30:31 +01:00
Fru: Fix edit field not checking area existence

I'm not sure I see where there is indentation inconsistency... The else is indented to align with the if statement it follows.

Lexden commented on pull request IPMITool/ipmitool#1 2023年10月31日 01:35:45 +01:00
Fru: Fix edit field not checking area existence

I see my misunderstanding now, thank you. I have updated this.

Lexden pushed to master at Lexden/ipmitool 2023年10月31日 01:34:17 +01:00
ce88a8bc6c Fix Multi-Record Area Length Calculation
Lexden commented on pull request IPMITool/ipmitool#1 2023年10月31日 00:38:10 +01:00
Fru: Fix edit field not checking area existence

I see, I misunderstood how the MRA was formatted, I have looked back through the spec and I see what you mean. I will correct that part.

Lexden pushed to master at Lexden/ipmitool 2023年10月31日 00:34:40 +01:00
2db59b0c07 Add changes dropped from previous commit
Lexden pushed to master at Lexden/ipmitool 2023年10月30日 23:51:12 +01:00
e469d66cef Refactor Code and Fix Logic Error