- United Kingdom
- https://leonardobishop.net
-
Full-time software engineer, and enjoyer of all things Free and Open Source.
-
Joined on
2024年12月29日
LGTM, the shield looks like this on Android:
You just need to add a couple of cases here for...
Also, you need to update RoadShieldType.cpp to include cases for Brazil_National and Brazil_State
roadShield.m_additionalText should stay the same
This doesn't compile (see CI). Is your branch based on main?
Makes sense, although this would rely on changes in your branch from #4710. Do you want me to adopt those changes here and you can rebase? Or do you want to update it instead
I'm not sure if this is the best place for this logic. I would rather this text be conveyed in the RoadShield object (with a field like m_displayText), which the individual parser classes...