argon2 build without optimizations #30

hakerdefo commented 2023年01月01日 18:30:36 +01:00 (Migrated from github.com)

argon2 build without optimizations as the previous build caused illegal instructions on certain CPUs.

argon2 build without optimizations as the previous build caused illegal instructions on certain CPUs.

demmm commented 2023年01月01日 19:29:56 +01:00 (Migrated from github.com)

As mentioned on Matrix, Argon2 has not changed in over 2 years, issue with keepassxc strated just a week ago on your system, so not changing Argon2 for all users because of your system, until clearer what you have going on. As asked before, full SysInfo log is needed.

As mentioned on Matrix, Argon2 has not changed in over 2 years, issue with keepassxc strated just a week ago on your system, so not changing Argon2 for all users because of your system, until clearer what you have going on. As asked before, full SysInfo log is needed.

hakerdefo commented 2023年01月03日 17:17:42 +01:00 (Migrated from github.com)

@demmm
I tested argon2 standalone and it gave me the following error,

Illegal instruction (core dumped)

Apparently when build with optimization, argon2 will error out with illegal instructions on many processors. Arch Linux fixed this exact bug in Jan 8, 2018,

github.com/archlinux/svntogit-packages@fdf4c3b0da

The same bug reported in Debian in 2016,

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828779

And, in Fedora in 2016,

https://bugzilla.redhat.com/show_bug.cgi?id=1512845

Why it didn't occur in my system previously? Well, I think I might have used AES-KDF in Keepassxc previously and hence argon2 wasn't used.

@demmm I tested argon2 standalone and it gave me the following error, > Illegal instruction (core dumped) Apparently when build with optimization, argon2 will error out with illegal instructions on many processors. Arch Linux fixed this exact bug in Jan 8, 2018, https://github.com/archlinux/svntogit-packages/commit/fdf4c3b0da6a02d52ce845b511edadbf66b4711a The same bug reported in Debian in 2016, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=828779 And, in Fedora in 2016, https://bugzilla.redhat.com/show_bug.cgi?id=1512845 Why it didn't occur in my system previously? Well, I think I might have used AES-KDF in Keepassxc previously and hence argon2 wasn't used.

demmm commented 2023年01月03日 17:51:44 +01:00 (Migrated from github.com)

Again, SysInfo is needed, keepassxc is used by many in KaOS (and as soon there is anything wrong with keepassxc, it is reported immediately), so not changing Argon2 for one user who so far refuses to provide much needed logs.

Again, SysInfo is needed, keepassxc is used by many in KaOS (and as soon there is anything wrong with keepassxc, it is reported immediately), so not changing Argon2 for one user who so far refuses to provide much needed logs.

hakerdefo commented 2023年01月03日 17:56:06 +01:00 (Migrated from github.com)

Again, SysInfo is needed, keepassxc is used by many in KaOS (and as soon there is anything wrong with keepassxc, it is reported immediately), so not changing Argon2 for one user who so far refuses to provide much needed logs.

Here you go buddy,

https://go.0xfc.de/1n3rz1

> Again, SysInfo is needed, keepassxc is used by many in KaOS (and as soon there is anything wrong with keepassxc, it is reported immediately), so not changing Argon2 for one user who so far refuses to provide much needed logs. Here you go buddy, https://go.0xfc.de/1n3rz1

demmm commented 2023年01月03日 18:47:56 +01:00 (Migrated from github.com)

Nothing in the logs that shows a cause for this issue.
KaOS is much more aligned with Gentoo, then distro's you link. Gentoo sets OPT still as 1 by default, if SSE2 is enabled:
https://gitweb.gentoo.org/repo/gentoo.git/commit/app-crypt/argon2?id=b71890e7ec94187258bbd0de4553d8dd8d339efd

More research needed before this PR will be considered. Will keep you posted.
See the discussion:
https://github.com/P-H-C/phc-winner-argon2/pull/113

Nothing in the logs that shows a cause for this issue. KaOS is much more aligned with Gentoo, then distro's you link. Gentoo sets OPT still as 1 by default, if SSE2 is enabled: https://gitweb.gentoo.org/repo/gentoo.git/commit/app-crypt/argon2?id=b71890e7ec94187258bbd0de4553d8dd8d339efd More research needed before this PR will be considered. Will keep you posted. See the discussion: https://github.com/P-H-C/phc-winner-argon2/pull/113

hakerdefo commented 2023年01月03日 19:14:31 +01:00 (Migrated from github.com)

@demmm
Okay, I hope you won't forget about this one and will get around to resolving this.

@demmm Okay, I hope you won't forget about this one and will get around to resolving this.

hakerdefo commented 2023年01月03日 20:45:02 +01:00 (Migrated from github.com)

@demmm

I compiled the argon2 package on my system using makepkg without changing any flags in the default PKGFILE and then installed the compiled binary and guess what? It works like a charm. So for me, the issue is gone but hopefully, you'll dig deep and may be figure out why pre-compiled binary ended-up throwing illegal instructions error on my CPU.

P.S. The working self compiled binary perhaps explains why Gentoo hasn't changed OPT as it is a source based distribution and users compile the stuff on their own machines instead of using pre-built binaries.

@demmm I compiled the argon2 package on my system using `makepkg` without changing any flags in the default PKGFILE and then installed the compiled binary and guess what? It works like a charm. So for me, the issue is gone but hopefully, you'll dig deep and may be figure out why pre-compiled binary ended-up throwing `illegal instructions `error on my CPU. P.S. The working self compiled binary perhaps explains why Gentoo hasn't changed OPT as it is a source based distribution and users compile the stuff on their own machines instead of using pre-built binaries.

This pull request has changes conflicting with the target branch.