2
4
Fork
You've already forked apps
1

Add kompare and krename to krusader #209

Closed
ShalokShalom wants to merge 1 commit from patch-10 into master
pull from: patch-10
merge into: KaOS:master
KaOS:master
ShalokShalom commented 2022年02月28日 11:04:34 +01:00 (Migrated from github.com)
Copy link

This adds diff and batch renaming

This adds diff and batch renaming
demmm commented 2022年02月28日 11:23:38 +01:00 (Migrated from github.com)
Copy link

Depends listed are needed, not options, make sure to read what the app itself does:
https://invent.kde.org/utilities/krusader/-/blob/master/krusader/krslots.cpp#L193
It does warn already for you to choose a diff option, same for krename.

Depends listed are needed, not options, make sure to read what the app itself does: https://invent.kde.org/utilities/krusader/-/blob/master/krusader/krslots.cpp#L193 It does warn already for you to choose a diff option, same for krename.
ShalokShalom commented 2022年02月28日 11:50:04 +01:00 (Migrated from github.com)
Copy link

Since the last 7 years, KaOS always included everything, since avoiding optdepends is part of the philosophy.
I didn't knew that changed yet, while I guess it does so only for apps who show you, what else you can add.

Since the last 7 years, KaOS always included everything, since avoiding optdepends is part of the philosophy. I didn't knew that changed yet, while I guess it does so only for apps who show you, what else you can add.
demmm commented 2022年02月28日 11:58:58 +01:00 (Migrated from github.com)
Copy link

Make sure you actually understand what you are asking.
Kompare is part of the default install, but has never been a depend (hard) of dolphin, so anyone is free to remove kompare and use kdiff3 instead.
You are asking now to force your preference on all users by making kompare a hard depend of krusader, leaving them no option to remove it and use another they might prefer instead.
Seems again an issue of you choosing to do a minimal install, then complaining packages you want are not part of you're install (again, kompare is part of a normal install, so you not having it means you choose to remove it).

Make sure you actually understand what you are asking. Kompare is part of the default install, but has never been a depend (hard) of dolphin, so anyone is free to remove kompare and use kdiff3 instead. You are asking now to force your preference on all users by making kompare a hard depend of krusader, leaving them no option to remove it and use another they might prefer instead. Seems again an issue of you choosing to do a minimal install, then complaining packages you want are not part of you're install (again, kompare is part of a normal install, so you not having it means you choose to remove it).
ShalokShalom commented 2022年02月28日 12:18:06 +01:00 (Migrated from github.com)
Copy link

How does this count for krename and how can nobody choose an alternative, if Krusader gives you this option:

Screenshot_20220228_121732

How does this count for krename and how can nobody choose an alternative, if Krusader gives you this option: ![Screenshot_20220228_121732](https://user-images.githubusercontent.com/6344099/155974493-f78a112b-1b1d-4196-b213-4ce42a351cd2.png)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
KaOS/apps!209
Reference in a new issue
KaOS/apps
No description provided.
Delete branch "patch-10"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?