2
4
Fork
You've already forked apps
1

Correct skype icon #170

Closed
bvbfan wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: KaOS:master
KaOS:master
bvbfan commented 2018年12月10日 12:31:14 +01:00 (Migrated from github.com)
Copy link
No description provided.
demmm commented 2018年12月10日 12:39:40 +01:00 (Migrated from github.com)
Copy link

Why is the actions icon needed and not the usual apps icon?

Why is the actions icon needed and not the usual apps icon?
bvbfan commented 2018年12月10日 12:53:04 +01:00 (Migrated from github.com)
Copy link

Or you should provide icon as well, i don't have icon called simple skype on my installation. If it's part of Mina theme, you can have this package without Midna as well.

Or you should provide icon as well, i don't have icon called simple skype on my installation. If it's part of Mina theme, you can have this package without Midna as well.
demmm commented 2018年12月10日 12:56:50 +01:00 (Migrated from github.com)
Copy link

It is part of every KaOS install, it being available in midna & midna-dark, so it is already provided
apps/midna-themes 3.0.3-1 /usr/share/icons/midna/apps/48/skype.svg
apps/midna-themes 3.0.3-1 /usr/share/icons/midnadark/apps/48/skype.svg

It is part of every KaOS install, it being available in midna & midna-dark, so it is already provided apps/midna-themes 3.0.3-1 /usr/share/icons/midna/apps/48/skype.svg apps/midna-themes 3.0.3-1 /usr/share/icons/midnadark/apps/48/skype.svg
bvbfan commented 2018年12月10日 13:17:10 +01:00 (Migrated from github.com)
Copy link

Ok, if it's not a problem, when you uninstall Midna theme to does not have an icon is ok. I mean icon should be here or kde-common to depend on Midna (which will be disaster) or we can leave as is.

Ok, if it's not a problem, when you uninstall Midna theme to does not have an icon is ok. I mean icon should be here or kde-common to depend on Midna (which will be disaster) or we can leave as is.
demmm commented 2018年12月10日 13:20:25 +01:00 (Migrated from github.com)
Copy link

I'll add the icon to kde-common, so it won't be an actions icon for an app/menu entry. Thus won't be using this pull request.

I'll add the icon to kde-common, so it won't be an actions icon for an app/menu entry. Thus won't be using this pull request.
demmm commented 2018年12月10日 16:09:06 +01:00 (Migrated from github.com)
Copy link

And as a many times repeated note (last time), do not flag packages as outdated when you find an issue, those will be ignored and immediately removed. Use the proper bug reports channels.
https://kaosx.us/bugs

And as a many times repeated note (last time), do not flag packages as outdated when you find an issue, those will be ignored and immediately removed. Use the proper bug reports channels. https://kaosx.us/bugs

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
KaOS/apps!170
Reference in a new issue
KaOS/apps
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?