11
29
Fork
You've already forked ipmitool
33

Fix broken spacing in ipmi_dcmi.c #72

Open
Matlib wants to merge 1 commit from Matlib/ipmitool:matlib into master
pull from: Matlib/ipmitool:matlib
merge into: IPMITool:master
IPMITool:master
IPMITool:bugfix/43-Fix-timezone-and-DST-in-SEL
IPMITool:pages
IPMITool:bugfix/fix-ci-builds
IPMITool:feature/refactor-sdr-name-handling
IPMITool:cleanup/nm
IPMITool:feature/add-support-for-boot-mailbox
IPMITool:codefactor
IPMITool:bugfix/26
First-time contributor
Copy link

Those new time functions wrecked the dcmi power reading output. There might be more occurrences like this because asctime() was used quite a lot in the code.

Those new time functions wrecked the `dcmi power reading` output. There might be more occurrences like this because asctime() was used quite a lot in the code.
Matlib changed title from (削除) WIP: Fix broken spacing in ipmi_dcmi.c (削除ここまで) to Fix broken spacing in ipmi_dcmi.c 2025年10月26日 00:32:50 +02:00

It's funny how for 7 years nobody even noticed that. Looks like a very useful function. :)
Thanks for the catch though!

It's funny how for 7 years nobody even noticed that. Looks like a very useful function. :) Thanks for the catch though!

If you don't mind, could you please review all the places where asctime was replaced by new function in commit f0d5c17ea7 and fix them as well?

If you don't mind, could you please review all the places where `asctime` was replaced by new function in commit f0d5c17ea7b2b5b815f24b101d35ddda1a88d8a4 and fix them as well?
Author
First-time contributor
Copy link

nm statistics
Can't verify because I'm getting error NM request failed because: Unknown (0xC1) (c1) on my hardware, however:

  • lib/ipmi_dcmi.c line 2953 – intended to have no new line (CSV output),
  • line 2981 – new line had already been there.

ipmi_delloem.c
I do not own such hardware but it should be wrong due to missing new lines.

ekanalyzer
I don't know how to use this command but new line was added.

fru
New line was added in the original commit and the command gives correct output.

**nm statistics** Can't verify because I'm getting error _NM request failed because: Unknown (0xC1) (c1)_ on my hardware, however: * lib/ipmi_dcmi.c line 2953 – intended to have no new line (CSV output), * line 2981 – new line had already been there. **ipmi_delloem.c** I do not own such hardware but it should be wrong due to missing new lines. **ekanalyzer** I don't know how to use this command but new line was added. **fru** New line was added in the original commit and the command gives correct output.
AlexanderAmelkin force-pushed matlib from 87851cb90b
Some checks are pending
ci/woodpecker/pr/woodpecker/1 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/2 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/3 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/4 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/5 Pipeline is pending approval
ci/woodpecker/pr/woodpecker/6 Pipeline is pending approval
to ff35022201 2025年12月26日 10:28:24 +01:00 Compare
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u matlib:Matlib-matlib
git switch Matlib-matlib
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!72
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "Matlib/ipmitool:matlib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?