11
29
Fork
You've already forked ipmitool
33

fru: edit: Refix commit 6d0a28f1c3 (crash in fru edit) #70

Merged
AlexanderAmelkin merged 3 commits from bugifix/69-Refix-6d0a28f1c3 into master 2025年10月23日 02:43:30 +02:00

As described in #69, fru edit crashed after commit 6d0a28f1c3.
It was identified that the reason was in wrong declaration of FRU area related structures that the aforementioned commit have optimistically used.
Also, a couple of out-of-bounds errors in the FRU modification code were found with valgrind and fixed with this PR.

As described in #69, `fru edit` crashed after commit 6d0a28f1c3. It was identified that the reason was in wrong declaration of FRU area related structures that the aforementioned commit have optimistically used. Also, a couple of out-of-bounds errors in the FRU modification code were found with valgrind and fixed with this PR.
AlexanderAmelkin changed title from (削除) fru: edit: Refix commit 6d0a28f1c3 (crash in fru edit) (削除ここまで) to WIP: fru: edit: Refix commit 6d0a28f1c3 (crash in fru edit) 2025年10月15日 17:09:04 +02:00
AlexanderAmelkin changed title from (削除) WIP: fru: edit: Refix commit 6d0a28f1c3 (crash in fru edit) (削除ここまで) to fru: edit: Refix commit 6d0a28f1c3 (crash in fru edit) 2025年10月15日 17:09:09 +02:00
k_pakhomov requested changes 2025年10月15日 18:32:54 +02:00
Dismissed
@ -94,2 +93,2 @@
#pragma pack(pop)
#endif
#define FRU_BLOCKS(b) (((b) + FRU_BLOCK_SZ - 1) / FRU_BLOCK_SZ)
#define FRU_BYTES_ROUNDED(bytes) (FRU_BYTES(FRU_BLOCSK(bytes)))
Contributor
Copy link

FRU_BLOCSK
typo

> FRU_BLOCSK typo
AlexanderAmelkin force-pushed bugifix/69-Refix-6d0a28f1c3 from 25a803781e to c62123d1c1 2025年10月16日 17:41:52 +02:00 Compare
AlexanderAmelkin force-pushed bugifix/69-Refix-6d0a28f1c3 from c62123d1c1 to 7727519a66
All checks were successful
ci/woodpecker/pr/woodpecker/1 Pipeline was successful
ci/woodpecker/pr/woodpecker/2 Pipeline was successful
ci/woodpecker/pr/woodpecker/5 Pipeline was successful
ci/woodpecker/pr/woodpecker/6 Pipeline was successful
ci/woodpecker/pr/woodpecker/3 Pipeline was successful
ci/woodpecker/pr/woodpecker/4 Pipeline was successful
ci/woodpecker/push/woodpecker/4 Pipeline was successful
ci/woodpecker/push/woodpecker/5 Pipeline was successful
ci/woodpecker/push/woodpecker/2 Pipeline was successful
ci/woodpecker/push/woodpecker/6 Pipeline was successful
ci/woodpecker/push/woodpecker/3 Pipeline was successful
ci/woodpecker/push/woodpecker/1 Pipeline was successful
2025年10月23日 02:18:06 +02:00 Compare
AlexanderAmelkin deleted branch bugifix/69-Refix-6d0a28f1c3 2025年10月23日 02:43:32 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!70
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "bugifix/69-Refix-6d0a28f1c3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?