11
29
Fork
You've already forked ipmitool
33

Support VITA specification revsion 2.x for discovery #6

Closed
hthiery wants to merge 1 commit from hthiery/ipmitool:feature/vita-extension into master
pull from: hthiery/ipmitool:feature/vita-extension
merge into: IPMITool:master
IPMITool:master
IPMITool:bugfix/43-Fix-timezone-and-DST-in-SEL
IPMITool:pages
IPMITool:bugfix/fix-ci-builds
IPMITool:feature/refactor-sdr-name-handling
IPMITool:cleanup/nm
IPMITool:feature/add-support-for-boot-mailbox
IPMITool:codefactor
IPMITool:bugfix/26
First-time contributor
Copy link

Signed-off-by: Heiko Thiery heiko.thiery@gmail.com

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
@ -211,3 +211,3 @@
lprintf(LOG_INFO, "Unknown VSO Standard %d",
(rsp->data[3] & 0x03));
} else if ((rsp->data[4] & 0x0F) != 1) {
} else if ((rsp->data[4] & 0x0F) != 1 && (rsp->data[4] & 0x0F) != 2) {

Are you sure that it is safe to assume vita_avail for revision 2.x without actually adding support for it in the calling code? At least an explanation in a comment somewhere near else below is needed to explain why this approach is safe.

Are you sure that it is safe to assume `vita_avail` for revision 2.x without actually adding support for it in the calling code? At least an explanation in a comment somewhere near `else` below is needed to explain why this approach is safe.

Closing this w/o merging as the author doesn't seem to care anymore, and the change is dubious.

Closing this w/o merging as the author doesn't seem to care anymore, and the change is dubious.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!6
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "hthiery/ipmitool:feature/vita-extension"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?