11
29
Fork
You've already forked ipmitool
33

Fix get_bmc_ip failure caused by search rule issue #52

Closed
zhangzikang wants to merge 2 commits from (deleted):master into master
pull from: (deleted):master
merge into: IPMITool:master
IPMITool:master
IPMITool:bugfix/43-Fix-timezone-and-DST-in-SEL
IPMITool:pages
IPMITool:bugfix/fix-ci-builds
IPMITool:feature/refactor-sdr-name-handling
IPMITool:cleanup/nm
IPMITool:feature/add-support-for-boot-mailbox
IPMITool:codefactor
IPMITool:bugfix/26
Contributor
Copy link

contrib: Fix redhat exchange-bmc-os-info script

There was a bug in the match rule when looking for the BMC's IP address

Resolves #46

Signed-off-by: zhangzikang zhangzikang@kylinos.cn

contrib: Fix redhat exchange-bmc-os-info script  There was a bug in the match rule when looking for the BMC's IP address  Resolves https://codeberg.org/IPMITool/ipmitool/issues/46 Signed-off-by: zhangzikang <zhangzikang@kylinos.cn>
zhangzikang changed title from (削除) Fix get_bmc_ip failure caused by search rule issue (削除ここまで) to WIP: Fix get_bmc_ip failure caused by search rule issue 2024年12月05日 07:43:07 +01:00
zhangzikang changed title from (削除) WIP: Fix get_bmc_ip failure caused by search rule issue (削除ここまで) to Fix get_bmc_ip failure caused by search rule issue 2024年12月05日 07:43:22 +01:00
@ -202,2 +202,2 @@
[ $(${IPMI_TOOL} lan print ${CHANNEL} 2>/dev/null \
| grep -q "^Set") ] || break
${IPMI_TOOL} lan print ${CHANNEL} 2>/dev/null \
| grep -q "^IP Address .*:" && break

I suggest combining this check with assigning TMP_IPv4 that takes place below. That would allow us to get rid of duplicate calls to ipmitool.

I suggest combining this check with assigning `TMP_IPv4` that takes place below. That would allow us to get rid of duplicate calls to `ipmitool`.
Author
Contributor
Copy link

Thank you for your suggestion. I have completed the modifications.

Thank you for your suggestion. I have completed the modifications.
zhangzikang marked this conversation as resolved

Also, please change the commit log to:

contrib: Fix redhat exchange-bmc-os-info script
There was a bug in the match rule when looking for the
BMC's IP address
Resolves https://codeberg.org/IPMITool/ipmitool/issues/46
Signed-off-by: ...
Also, please change the commit log to: ``` contrib: Fix redhat exchange-bmc-os-info script There was a bug in the match rule when looking for the BMC's IP address Resolves https://codeberg.org/IPMITool/ipmitool/issues/46 Signed-off-by: ... ```
Author
Contributor
Copy link

@AlexanderAmelkin I have completed the modifications according to your suggestions, please review. Thank you very much.

@AlexanderAmelkin I have completed the modifications according to your suggestions, please review. Thank you very much.
Author
Contributor
Copy link

@AlexanderAmelkin Please assist in reviewing. Thank you.

@AlexanderAmelkin Please assist in reviewing. Thank you.

Please rebase the branch to the current master branch, don't bring merge commits into the branch of this PR

Please rebase the branch to the current master branch, don't bring merge commits into the branch of this PR

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!52
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?