11
29
Fork
You've already forked ipmitool
33

Add remote cdrom support in ipmi_chassis_set_bootdev #49

Merged
AlexanderAmelkin merged 2 commits from yanggang/ipmitool:feature/bootdev-remotecdrom-support into master 2024年12月02日 17:39:35 +01:00
Contributor
Copy link
No description provided.
@ -1267,6 +1267,11 @@ ipmi_chassis_set_bootdev(struct ipmi_intf * intf, char * arg, uint8_t *iflags)
{
flags[1] |= 0x14;
}
else if (!strcmp(arg, "remotecdrom") ||

Don't you think that a shorter name like remotecd would be more convenient?

Don't you think that a shorter name like `remotecd` would be more convenient?
Author
Contributor
Copy link

remotecd is ok and will be more convenient, i'll update it.

`remotecd` is ok and will be more convenient, i'll update it.
yanggang marked this conversation as resolved
@ -1268,2 +1268,4 @@
flags[1] |= 0x14;
}
else if (!strcmp(arg, "remotecdrom") ||
!strcmp(arg, "force_remotecdrom"))

Please use tabs for indentation, spaces for alignment everywhere.
That is:

	else if (!strcmp(arg, "remotecdrom") ||
	 !strcmp(arg, "force_remotecdrom"))
Please use `tabs for indentation, spaces for alignment` everywhere. That is: ``` else if (!strcmp(arg, "remotecdrom") || !strcmp(arg, "force_remotecdrom")) ```
Author
Contributor
Copy link

Got it. I'll update the code.

Thanks for the comments.

btw: i found there have some another code use tabs for alignment, i think we can update it later.

Got it. I'll update the code. Thanks for the comments. btw: i found there have some another code use `tabs for alignment`, i think we can update it later.

some another code use tabs for alignment

yes, there is a lot of legacy code that is formatted badly.
I usually ask to update it when someone touches it.

> some another code use `tabs for alignment` yes, there is a lot of legacy code that is formatted badly. I usually ask to update it when someone touches it.
yanggang marked this conversation as resolved
yanggang force-pushed feature/bootdev-remotecdrom-support from d30c9be083 to abaddb87ad 2024年11月22日 03:18:39 +01:00 Compare
Author
Contributor
Copy link

code updated

  1. remotecdrom --> remotecd
  2. use spaces for alignment
code updated 1. `remotecdrom` --> `remotecd` 2. use `spaces for alignment`
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!49
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "yanggang/ipmitool:feature/bootdev-remotecdrom-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?