11
29
Fork
You've already forked ipmitool
33

sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 #39

Merged
AlexanderAmelkin merged 1 commit from dwise0315/ipmitool:bugfix/8-sel_sensor_lun1 into master 2025年09月11日 16:29:55 +02:00
Contributor
Copy link

IPMI specification only allows for a 1 byte sensor number field, in
AMI SP-X firmware owner lun bits(1:0) in the SDR may be used to
extend sensor count beyond 255 sensors

The change will add checking of SEL Generator ID byte 2 LUN bits [1:0]
in the compare with the SDR LUN field to display the correct SDR string
in the SEL event

signed-off-by: dwise0315 david.wise.atl@gmail.com

IPMI specification only allows for a 1 byte sensor number field, in AMI SP-X firmware owner lun bits(1:0) in the SDR may be used to extend sensor count beyond 255 sensors The change will add checking of SEL Generator ID byte 2 LUN bits [1:0] in the compare with the SDR LUN field to display the correct SDR string in the SEL event signed-off-by: dwise0315 <david.wise.atl@gmail.com>
IPMI specification only allows for a 1 byte sensor number field, in
AMI SP-X firmware owner lun bits(1:0) in the SDR may be used to
extend sensor count beyond 255 sensors
The change will add checking of SEL Generator ID byte 2 LUN bits [1:0]
in the compare with the SDR LUN field to display the correct SDR string
in the SEL event
signed-off-by: dwise0315 <david.wise.atl@gmail.com>
dwise0315 changed title from (削除) WIP: sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 (削除ここまで) to sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 2024年08月05日 20:15:42 +02:00
First-time contributor
Copy link

Hi, are there any updates on whether this PR is expected to be merged soon?

Hi, are there any updates on whether this PR is expected to be merged soon?
First-time contributor
Copy link

Hi, I'd also like to add that Nvidia has tested this patch and confirmed that it fixes their bug:

Previously, the SEL events for SPD_FAN_[1..4]5 plus SPD_FAN_4[1..4] were not properly reported. E.g. these IDs for these fans were 0x1a0-0x1a7, and only the lower byte was being used.

# ipmitool -V
ipmitool version 1.8.18
ipmitool sel elist log as below:
| 08/07/2024 | 09:41:47 | Fan SPD_FAN_1_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:41:47 | Fan SPD_FAN_1_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:42:14 | Fan SPD_FAN_1_5_R | Lower Critical going low | Deasserted | Reading 4840 < Threshold 2200 RPM
| 08/07/2024 | 09:42:14 | Fan SPD_FAN_1_5_F | Lower Critical going low | Deasserted | Reading 5720 < Threshold 2464 RPM
| 08/07/2024 | 09:42:31 | Fan SPD_FAN_2_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:42:31 | Fan SPD_FAN_2_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:43:00 | Fan SPD_FAN_2_5_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM
| 08/07/2024 | 09:43:00 | Fan SPD_FAN_2_5_F | Lower Critical going low | Deasserted | Reading 4224 < Threshold 2464 RPM
| 08/07/2024 | 09:43:23 | Fan SPD_FAN_3_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:43:23 | Fan SPD_FAN_3_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:43:58 | Fan SPD_FAN_3_5_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM
| 08/07/2024 | 09:44:03 | Fan SPD_FAN_3_5_F | Lower Critical going low | Deasserted | Reading 5632 < Threshold 2464 RPM
| 08/07/2024 | 09:44:14 | Fan SPD_FAN_4_1_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:44:16 | Fan SPD_FAN_4_1_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:44:37 | Fan SPD_FAN_4_1_R | Lower Critical going low | Deasserted | Reading 3608 < Threshold 2200 RPM
| 08/07/2024 | 09:44:37 | Fan SPD_FAN_4_1_F | Lower Critical going low | Deasserted | Reading 4312 < Threshold 2464 RPM
| 08/07/2024 | 09:44:59 | Fan SPD_FAN_4_2_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:45:00 | Fan SPD_FAN_4_2_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:45:34 | Fan SPD_FAN_4_2_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM
| 08/07/2024 | 09:45:34 | Fan SPD_FAN_4_2_F | Lower Critical going low | Deasserted | Reading 4136 < Threshold 2464 RPM
| 08/07/2024 | 09:45:49 | Fan SPD_FAN_4_3_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:45:49 | Fan SPD_FAN_4_3_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:46:09 | Fan SPD_FAN_4_3_R | Lower Critical going low | Deasserted | Reading 3168 < Threshold 2200 RPM
| 08/07/2024 | 09:46:09 | Fan SPD_FAN_4_3_F | Lower Critical going low | Deasserted | Reading 3608 < Threshold 2464 RPM
| 08/07/2024 | 09:46:24 | Fan SPD_FAN_4_4_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:46:24 | Fan SPD_FAN_4_4_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:46:46 | Fan SPD_FAN_4_4_R | Lower Critical going low | Deasserted | Reading 3784 < Threshold 2200 RPM
| 08/07/2024 | 09:46:46 | Fan SPD_FAN_4_4_F | Lower Critical going low | Deasserted | Reading 4400 < Threshold 2464 RPM
| 08/07/2024 | 09:47:14 | Fan SPD_FAN_4_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM
| 08/07/2024 | 09:47:14 | Fan SPD_FAN_4_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM
| 08/07/2024 | 09:48:58 | Fan SPD_FAN_4_5_R | Lower Critical going low | Deasserted | Reading 2288 < Threshold 2200 RPM
| 08/07/2024 | 09:49:01 | Fan SPD_FAN_4_5_F | Lower Critical going low | Deasserted | Reading 6424 < Threshold 2464 RPM
Hi, I'd also like to add that Nvidia has tested this patch and confirmed that it fixes their bug: Previously, the SEL events for SPD_FAN_[1..4]_5 plus SPD_FAN_4_[1..4] were not properly reported. E.g. these IDs for these fans were 0x1a0-0x1a7, and only the lower byte was being used. ``` # ipmitool -V ipmitool version 1.8.18 ipmitool sel elist log as below: | 08/07/2024 | 09:41:47 | Fan SPD_FAN_1_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:41:47 | Fan SPD_FAN_1_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:42:14 | Fan SPD_FAN_1_5_R | Lower Critical going low | Deasserted | Reading 4840 < Threshold 2200 RPM | 08/07/2024 | 09:42:14 | Fan SPD_FAN_1_5_F | Lower Critical going low | Deasserted | Reading 5720 < Threshold 2464 RPM | 08/07/2024 | 09:42:31 | Fan SPD_FAN_2_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:42:31 | Fan SPD_FAN_2_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:43:00 | Fan SPD_FAN_2_5_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM | 08/07/2024 | 09:43:00 | Fan SPD_FAN_2_5_F | Lower Critical going low | Deasserted | Reading 4224 < Threshold 2464 RPM | 08/07/2024 | 09:43:23 | Fan SPD_FAN_3_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:43:23 | Fan SPD_FAN_3_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:43:58 | Fan SPD_FAN_3_5_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM | 08/07/2024 | 09:44:03 | Fan SPD_FAN_3_5_F | Lower Critical going low | Deasserted | Reading 5632 < Threshold 2464 RPM | 08/07/2024 | 09:44:14 | Fan SPD_FAN_4_1_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:44:16 | Fan SPD_FAN_4_1_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:44:37 | Fan SPD_FAN_4_1_R | Lower Critical going low | Deasserted | Reading 3608 < Threshold 2200 RPM | 08/07/2024 | 09:44:37 | Fan SPD_FAN_4_1_F | Lower Critical going low | Deasserted | Reading 4312 < Threshold 2464 RPM | 08/07/2024 | 09:44:59 | Fan SPD_FAN_4_2_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:45:00 | Fan SPD_FAN_4_2_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:45:34 | Fan SPD_FAN_4_2_R | Lower Critical going low | Deasserted | Reading 3520 < Threshold 2200 RPM | 08/07/2024 | 09:45:34 | Fan SPD_FAN_4_2_F | Lower Critical going low | Deasserted | Reading 4136 < Threshold 2464 RPM | 08/07/2024 | 09:45:49 | Fan SPD_FAN_4_3_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:45:49 | Fan SPD_FAN_4_3_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:46:09 | Fan SPD_FAN_4_3_R | Lower Critical going low | Deasserted | Reading 3168 < Threshold 2200 RPM | 08/07/2024 | 09:46:09 | Fan SPD_FAN_4_3_F | Lower Critical going low | Deasserted | Reading 3608 < Threshold 2464 RPM | 08/07/2024 | 09:46:24 | Fan SPD_FAN_4_4_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:46:24 | Fan SPD_FAN_4_4_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:46:46 | Fan SPD_FAN_4_4_R | Lower Critical going low | Deasserted | Reading 3784 < Threshold 2200 RPM | 08/07/2024 | 09:46:46 | Fan SPD_FAN_4_4_F | Lower Critical going low | Deasserted | Reading 4400 < Threshold 2464 RPM | 08/07/2024 | 09:47:14 | Fan SPD_FAN_4_5_R | Lower Critical going low | Asserted | Reading 0 < Threshold 2200 RPM | 08/07/2024 | 09:47:14 | Fan SPD_FAN_4_5_F | Lower Critical going low | Asserted | Reading 0 < Threshold 2464 RPM | 08/07/2024 | 09:48:58 | Fan SPD_FAN_4_5_R | Lower Critical going low | Deasserted | Reading 2288 < Threshold 2200 RPM | 08/07/2024 | 09:49:01 | Fan SPD_FAN_4_5_F | Lower Critical going low | Deasserted | Reading 6424 < Threshold 2464 RPM ```
dwise0315 changed title from (削除) sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 (削除ここまで) to WIP: sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 2024年12月24日 16:05:40 +01:00
dwise0315 changed title from (削除) WIP: sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 (削除ここまで) to sel/sdr : Fix SEL cannot display Sensor name when sensor owner lun1 2024年12月24日 16:05:46 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
IPMITool/ipmitool!39
Reference in a new issue
IPMITool/ipmitool
No description provided.
Delete branch "dwise0315/ipmitool:bugfix/8-sel_sensor_lun1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?