GramEditor/gram
38
986
Fork
You've already forked gram
88

Increase contrast of selected item in Prompt window #156

Merged
krig merged 1 commit from tjk/gram:prompt-selection-contrast into main 2026年03月24日 08:44:58 +01:00
Contributor
Copy link
There were 5 themes that used practically the same color for
info.background and element.background. Those are used in Prompt
windows (e.g. save / don't save / cancel) to distinguish the selected
item, which is important for keyboard navigation.
This change changes info.background to match element.selected for those
themes, which highlights the selected option in a theme-appropriate
color.

Fixes #153

I looked around the interface at some of the other places that use this color (grep for info_background) in RPM and Tokyo themes and I didn't see anything that looks odd to me, though I'm not a designer. A better solution may be to leave the colors as-is and change the prompt window to use a different color for highlighting the selected item, but I couldn't figure out how; I don't think it's referencing info_background like other places that use the color.

Note that there's still an issue where keyboard and mouse selections are different, and hovering the mouse over the keyboard-selected item makes it turn a color that doesn't seem to fit the theme as well - maybe the two highlight colors are being blended? But this happens with untouched themes as well, and it's only cosmetic.

```plain There were 5 themes that used practically the same color for info.background and element.background. Those are used in Prompt windows (e.g. save / don't save / cancel) to distinguish the selected item, which is important for keyboard navigation. This change changes info.background to match element.selected for those themes, which highlights the selected option in a theme-appropriate color. ``` Fixes #153 I looked around the interface at some of the other places that use this color (grep for `info_background`) in RPM and Tokyo themes and I didn't see anything that looks odd to me, though I'm not a designer. A better solution may be to leave the colors as-is and change the prompt window to use a different color for highlighting the selected item, but I couldn't figure out how; I don't think it's referencing `info_background` like other places that use the color. Note that there's still an issue where keyboard and mouse selections are different, and hovering the mouse over the keyboard-selected item makes it turn a color that doesn't seem to fit the theme as well - maybe the two highlight colors are being blended? But this happens with untouched themes as well, and it's only cosmetic.
There were 5 themes that used practically the same color for
info.background and element.background. Those are used in Prompt
windows (e.g. save / don't save / cancel) to distinguish the selected
item, which is important for keyboard navigation.
This change changes info.background to match element.selected for those
themes, which highlights the selected option in a theme-appropriate
color.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GramEditor/gram!156
Reference in a new issue
GramEditor/gram
No description provided.
Delete branch "tjk/gram:prompt-selection-contrast"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?